8308089: [riscv-port-jdk17u] Intrinsify Unsafe.storeStoreFence

[zhengxiaolinX]

JDK-8252990 was recently backported to jdk17u in April. We should also enable the matching rule for StoreStoreFence on the WIP riscv-port-jdk17u repo.

Found the small fastdebug crash when backporting #51 using -Xcomp.

Testing a hotspot tier1~2 in progress.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8308089: [riscv-port-jdk17u] Intrinsify Unsafe.storeStoreFence

Reviewers

• Fei Yang (@RealFYang - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/riscv-port-jdk17u.git pull/52/head:pull/52
$ git checkout pull/52

Update a local copy of the PR:
$ git checkout pull/52
$ git pull https://git.openjdk.org/riscv-port-jdk17u.git pull/52/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 52

View PR using the GUI difftool:
$ git pr show -t 52

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/riscv-port-jdk17u/pull/52.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back xlinzheng! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 00: Full (fb467b42)

[RealFYang]

@zhengxiaolinX : Thanks for fixing this. The changes looks good to me.
Suggestion for the JBS issue title: [riscv-port-jdk17u] Intrinsify Unsafe.storeStoreFence

PS: I am referencing issue title naming convention for other project like lilliput: https://bugs.openjdk.org/browse/JDK-8302065

[openjdk]

@zhengxiaolinX This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308089: [riscv-port-jdk17u] Intrinsify Unsafe.storeStoreFence

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the riscv-port branch:

• 3a02888: 8306667: RISC-V: Fix storeImmN0 matching rule by using zr register
• 54a78c7: 8297359: RISC-V: improve performance of floating Max Min intrinsics
• cd7de11: 8296435: RISC-V: Small refactoring for increment/decrement

Please see this link for an up-to-date comparison between the source branch of this pull request and the riscv-port branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[zhengxiaolinX]

Thank you for reviewing!

Tier1 and tier2 passed.

/integrate

[openjdk]

@zhengxiaolinX
Your change (at version fb467b4) is now ready to be sponsored by a Committer.

[RealFYang]

/sponsor

[openjdk]

Going to push as commit 0bdef91.
Since your change was applied there have been 3 commits pushed to the riscv-port branch:

• 3a02888: 8306667: RISC-V: Fix storeImmN0 matching rule by using zr register
• 54a78c7: 8297359: RISC-V: improve performance of floating Max Min intrinsics
• cd7de11: 8296435: RISC-V: Small refactoring for increment/decrement

Your commit was automatically rebased without conflicts.

[openjdk]

@RealFYang @zhengxiaolinX Pushed as commit 0bdef91.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[VladimirKempik]

@RealFYang do you think we are ready now to try to go into jdk17u-dev ?

[RealFYang]

@RealFYang do you think we are ready now to try to go into jdk17u-dev ?

Still a couple of backports pending, like JDK-8307446. I was told those are currently under testing.
If everything goes well, I think we should be able to initiating the upstreaming early next month.