Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8279827: riscv: RVB: Add shift and add instructions #43

Closed
wants to merge 5 commits into from

Conversation

feilongjiang
Copy link
Member

@feilongjiang feilongjiang commented Jan 11, 2022

This PR implements shift left and add instructions: sh1add/sh2add/sh3add/sh1add.uw/sh2add.uw/sh3add.uw.

New C2 instructions are covered by JTREG test: test/jdk/java/lang

Hotspot and jdk tier1 tests on QEMU (with and without UseRVB) are passed without new failures.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8279827: riscv: RVB: Add shift and add instructions

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/riscv-port pull/43/head:pull/43
$ git checkout pull/43

Update a local copy of the PR:
$ git checkout pull/43
$ git pull https://git.openjdk.java.net/riscv-port pull/43/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 43

View PR using the GUI difftool:
$ git pr show -t 43

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/riscv-port/pull/43.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 11, 2022

👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into riscv-port will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 11, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 11, 2022

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@openjdk
Copy link

openjdk bot commented Jan 12, 2022

@feilongjiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279827: riscv: RVB: Add shift and add instructions

Reviewed-by: fyang, yzhu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the riscv-port branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 12, 2022
@feilongjiang
Copy link
Member Author

Thanks for the reviews! @yhzhu20 @RealFYang.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 12, 2022
@openjdk
Copy link

openjdk bot commented Jan 12, 2022

@feilongjiang
Your change (at version 4356b5a) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 12, 2022

Going to push as commit 6704993.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 12, 2022
@openjdk openjdk bot closed this Jan 12, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 12, 2022
@feilongjiang feilongjiang deleted the rvb-shadd branch January 12, 2022 06:17
@openjdk
Copy link

openjdk bot commented Jan 12, 2022

@RealFYang @feilongjiang Pushed as commit 6704993.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
3 participants