Avoid storing empty files

openjdk · Oct 20, 2020 · 7259825 · 7259825
1 parent 8f29ac9
commit 7259825
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/storage/src/main/java/org/openjdk/skara/storage/RepositoryStorage.java b/storage/src/main/java/org/openjdk/skara/storage/RepositoryStorage.java
@@ -25,6 +25,7 @@
 import org.openjdk.skara.vcs.Repository;
 
 import java.io.*;
+import java.nio.file.Files;
 import java.util.*;
 
 class RepositoryStorage<T> implements Storage<T> {
@@ -74,8 +75,13 @@ public void put(Collection<T> items) {
         }
         current = updated;
         try {
-            repository.add(repository.root().resolve(fileName));
+            var filePath = repository.root().resolve(fileName);
+            repository.add(filePath);
             repository.commit(message, authorName, authorEmail);
+
+            if (Files.size(filePath) == 0) {
+                throw new IllegalStateException("Storage file is empty: " + filePath);
+            }
         } catch (IOException e) {
             throw new UncheckedIOException(e);
         }