Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bot: add version handler #1165

Closed
wants to merge 1 commit into from
Closed

bot: add version handler #1165

wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented May 24, 2021

Hi all,

please review this patch that adds a version handler, typically listening on the path /version. This simple handler just returns the version of the running bots, useful for scripting or dashboards. Typical configuration:

{
  "http-server": {
    "/version": {
      "type": "version"
    }
  }
}

Example of usage:

$ curl http://localhost:8080/version
bd09ee70259733dc2e18577da6a36462c900dba3

Testing:

  • Tested locally on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/skara pull/1165/head:pull/1165
$ git checkout pull/1165

Update a local copy of the PR:
$ git checkout pull/1165
$ git pull https://git.openjdk.java.net/skara pull/1165/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1165

View PR using the GUI difftool:
$ git pr show -t 1165

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/skara/pull/1165.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 24, 2021

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into pr/1164 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label May 24, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented May 24, 2021

Webrevs

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/1164 to master May 28, 2021
@openjdk-notifier
Copy link

@openjdk-notifier openjdk-notifier bot commented May 28, 2021

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout profile-handler
git fetch https://git.openjdk.java.net/skara master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

@openjdk openjdk bot commented May 28, 2021

@edvbld this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout version-handler
git fetch https://git.openjdk.java.net/skara master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

@openjdk openjdk bot commented May 28, 2021

@edvbld This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

After integration, the commit message for the final commit will be:

bot: add version handler

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready and removed merge-conflict labels May 28, 2021
@edvbld
Copy link
Member Author

@edvbld edvbld commented May 28, 2021

/integrate

@openjdk openjdk bot closed this May 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 28, 2021

@edvbld Pushed as commit a166432.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants