Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

119: Support fetching Jira issues with only a partial id #183

Closed
wants to merge 1 commit into from

Conversation

@rwestberg
Copy link
Member

rwestberg commented Oct 4, 2019

Hi all,

Please review the following change that allows specifying Jira issues by number only, without a qualifying project name.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

⚠️ Failed to retrieve information on issue 119: Support fetching Jira issues with only a partial id.

Approvers

  • Erik Helin (ehelin - Reviewer)
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 4, 2019

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@openjdk openjdk bot added rfr bots labels Oct 4, 2019
@mlbridge
Copy link

mlbridge bot commented Oct 4, 2019

Webrevs

@edvbld
edvbld approved these changes Oct 4, 2019
Copy link
Member

edvbld left a comment

Looks good

@openjdk openjdk bot removed the rfr label Oct 4, 2019
@openjdk
Copy link

openjdk bot commented Oct 4, 2019

@rwestberg This change can now be integrated. The commit message will be:

119: Support fetching Jira issues with only a partial id

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To list additional contributors, use the /contributor command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch:

  • 5871660: 118: Use jcheck configuration from PR target branch
  • 70f9f00: Fix NPE in GitLabHost::isMemberOf
  • fc52685: Make it possible to cancel a Check

Since there are no conflicts, your changes will automatically be rebased on top of the above commits when integrating. If you prefer to do this manually, please merge master into your branch first.

  • To integrate this PR with the above commit message, type /integrate in a new comment.
@openjdk openjdk bot added the ready label Oct 4, 2019
@rwestberg
Copy link
Member Author

rwestberg commented Oct 4, 2019

/integrate

@openjdk openjdk bot closed this Oct 4, 2019
@openjdk openjdk bot added integrated and removed ready labels Oct 4, 2019
@openjdk
Copy link

openjdk bot commented Oct 4, 2019

@rwestberg The following commits have been pushed to master since your change was applied:

Your commit was automatically rebased without conflicts.
Pushed as commit c8b859f.

@mlbridge
Copy link

mlbridge bot commented Oct 4, 2019

Mailing list message from duke duke@openjdk.java.net

Changeset: c8b859f
Author: Robin Westberg
Date: 2019-10-04 11:57:16 +0000
URL: https://git.openjdk.java.net/skara/commit/c8b859f1

119: Support fetching Jira issues with only a partial id

Reviewed-by: ehelin

! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java
! host/src/main/java/org/openjdk/skara/host/jira/JiraProject.java
! test/src/main/java/org/openjdk/skara/test/TestHost.java
! test/src/main/java/org/openjdk/skara/test/TestIssueProject.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.