Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

236: Add links to issue in generated webrevs #371

Closed
wants to merge 2 commits into from
Closed

236: Add links to issue in generated webrevs #371

wants to merge 2 commits into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Jan 21, 2020 •
edited by openjdk bot

Hi all,

please review this patch that adds links to issues in automatically generated
webrevs (if the PR contains a link to an issue).

Thanks,
Erik

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

SKARA-236: Add links to issue in generated webrevs

Approvers

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 21, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request (refresh this page to view it).

@mlbridge
Copy link

mlbridge bot commented Jan 21, 2020 •
edited

Webrevs

rwestberg
rwestberg approved these changes Jan 21, 2020
View reviewed changes
Copy link
Member

@rwestberg rwestberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openjdk openjdk bot removed the rfr label Jan 21, 2020
@openjdk
Copy link

openjdk bot commented Jan 21, 2020 •
edited

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

236: Add links to issue in generated webrevs

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 21, 2020
@edvbld
Copy link
Member Author

edvbld commented Jan 21, 2020

/integrate

@openjdk openjdk bot closed this Jan 21, 2020
@openjdk openjdk bot added integrated and removed ready labels Jan 21, 2020
@openjdk
Copy link

openjdk bot commented Jan 21, 2020

@edvbld
Pushed as commit d206029.

@mlbridge
Copy link

mlbridge bot commented Jan 21, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: d206029
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-01-21 13:01:44 +0000
URL: https://git.openjdk.java.net/skara/commit/d2060299

236: Add links to issue in generated webrevs

Reviewed-by: rwestberg

! bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/WebrevStorage.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwestberg rwestberg rwestberg approved these changes

Assignees
No one assigned
Labels
bots integrated
Milestone
No milestone
2 participants
@edvbld @rwestberg