Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different scratch folders for different repos #427

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Feb 11, 2020

Hi all,

Please review this small change that ensures that different repositories get different scratch folders when inspected by the pullrequest bot, which should increase performance.

Best regards,
Robin

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Approvers

  • Erik Helin (ehelin - Reviewer)

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 11, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

Copy link
Member

@edvbld edvbld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openjdk
Copy link

openjdk bot commented Feb 11, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Use different scratch folders for different repos

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 11, 2020
@rwestberg
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Feb 11, 2020
@openjdk openjdk bot added integrated and removed ready labels Feb 11, 2020
@openjdk
Copy link

openjdk bot commented Feb 11, 2020

@rwestberg
Pushed as commit 9e9559a.

@openjdk openjdk bot removed the rfr label Feb 11, 2020
@mlbridge
Copy link

mlbridge bot commented Feb 11, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants