Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forge: add method diffUrl to PullRequest #459

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Feb 20, 2020

Hi all,

please review this small patch that adds the method PullRequest::diffUrl.
Although the implementation is the same for both GitHubPullRequest and
GitLabMergeRequest I chose to not do a default method to highlight that this
is more of a coincidence than a rule.

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/459/head:pull/459
$ git checkout pull/459

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 20, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

Copy link
Member

@rwestberg rwestberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@openjdk
Copy link

openjdk bot commented Feb 20, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

forge: add method diffUrl to PullRequest

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 529eedf992434fe1af01d445a4d1f7834829a17a.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 20, 2020
@edvbld
Copy link
Member Author

edvbld commented Feb 20, 2020

/integrate

@openjdk openjdk bot closed this Feb 20, 2020
@openjdk openjdk bot added integrated and removed ready labels Feb 20, 2020
@openjdk
Copy link

openjdk bot commented Feb 20, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • 529eedf: git-pr: use multi-command argument parser
  • 0feb780: 283: Pull request pruner bot should look at comments and reviews only

Your commit was automatically rebased without conflicts.

Pushed as commit 513a8e3.

@openjdk openjdk bot removed the rfr label Feb 20, 2020
@mlbridge
Copy link

mlbridge bot commented Feb 20, 2020

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants