Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

315: Publish command is not in GitSkara.java #515

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Mar 18, 2020

Hi all,

please review this small patch that adds the publish command to
GitSkara.java so that git skara publish works.

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-315: Publish command is not in GitSkara.java

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/515/head:pull/515
$ git checkout pull/515

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Mar 18, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 18, 2020

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Mar 18, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

315: Publish command is not in GitSkara.java

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch. Since there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 6c1dd66670b73f47462aa165b1ec3cd9243cc04e.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 18, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Mar 18, 2020

/integrate

@openjdk openjdk bot closed this Mar 18, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Mar 18, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • 6c1dd66: 319: git-info uses wrong JBS project
  • 4b7b969: 292: Add comment to PR when it becomes outdated
  • c0abd82: 317: git-webrev uses wrong JBS links for commit messages

Your commit was automatically rebased without conflicts.

Pushed as commit b180754.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Mar 18, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: b180754
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-03-18 10:04:35 +0000
URL: https://git.openjdk.java.net/skara/commit/b1807540

315: Publish command is not in GitSkara.java

Reviewed-by: rwestberg

! cli/src/main/java/org/openjdk/skara/cli/GitSkara.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants