New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git-sync: use refspec instead of --prune-tags #529
Conversation
👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there have been 7 commits pushed to the ➡️ To integrate this PR with the above commit message, type |
/integrate |
@edvbld The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit b2b8de2. |
Mailing list message from Erik Helin on skara-dev: Changeset: b2b8de2 git-sync: use refspec instead of --prune-tags Reviewed-by: rwestberg ! vcs/src/main/java/org/openjdk/skara/vcs/git/GitRepository.java |
Hi all,
please review this small patch that uses a refspec instead of
--prune-tags
forGitRepository.fetchRemote
. The flag--prune-tags
was introduced in Git 2.17and we want to support older Git versions, so I opted to use a refspec instead
to achieve the same effect.
Testing:
git sync
on Linux x64Thanks,
Erik
Progress
Reviewers
Download
$ git fetch https://git.openjdk.java.net/skara pull/529/head:pull/529
$ git checkout pull/529