Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

339: Only show link to CONTRIBUTING.md if it exists #551

Closed
wants to merge 1 commit into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Mar 30, 2020

Hi all,

please review this patch that ensures that the pull request only shows a link to
a CONTRIBUTING.md file in the integration message if a CONTRIBUTING.md
actually exists.

Testing:

  • Added two new unit tests
  • make test passes on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-339: Only show link to CONTRIBUTING.md if it exists

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/551/head:pull/551
$ git checkout pull/551

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 30, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

mlbridge bot commented Mar 30, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

openjdk bot commented Mar 30, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

339: Only show link to CONTRIBUTING.md if it exists

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

➡️ To integrate this PR with the above commit message, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Mar 30, 2020
@edvbld
Copy link
Member Author

edvbld commented Mar 30, 2020

/integrate

@openjdk openjdk bot closed this Mar 30, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Mar 30, 2020
@openjdk
Copy link

openjdk bot commented Mar 30, 2020

@edvbld
Pushed as commit 870bf78.

@mlbridge
Copy link

mlbridge bot commented Mar 30, 2020

Mailing list message from Erik Helin on skara-dev:

Changeset: 870bf78
Author: Erik Helin <ehelin at openjdk.org>
Date: 2020-03-30 14:28:00 +0000
URL: https://git.openjdk.java.net/skara/commit/870bf786

339: Only show link to CONTRIBUTING.md if it exists

Reviewed-by: rwestberg

! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java
! bots/pr/src/test/java/org/openjdk/skara/bots/pr/IntegrateTests.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants