Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3 compatibility for mercurial extension #593

Closed
wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Apr 22, 2020

Hi all,

Please review this change that makes the mercurial extension python 3 compatible.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

  • Erik Helin (ehelin - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/skara pull/593/head:pull/593
$ git checkout pull/593

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 22, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Apr 22, 2020
@mlbridge
Copy link

mlbridge bot commented Apr 22, 2020

Webrevs

edvbld
edvbld approved these changes Apr 22, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks good, thanks for fixing this!

@openjdk
Copy link

openjdk bot commented Apr 22, 2020

@rwestberg This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Python 3 compatibility for mercurial extension

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /solves command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch. As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate ef0c6f6cd8848a183f0c503102fc64e03396b145.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 22, 2020
@rwestberg
Copy link
Member Author

rwestberg commented Apr 23, 2020

/integrate

@openjdk openjdk bot closed this Apr 23, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Apr 23, 2020
@openjdk
Copy link

openjdk bot commented Apr 23, 2020

@rwestberg The following commits have been pushed to master since your change was applied:

  • ef0c6f6: Fix problem with specifying a single issue with shorthand syntax
  • 65cf0c4: mirror-bot: use to repo to restrict concurrency

Your commit was automatically rebased without conflicts.

Pushed as commit 0c38106.

@mlbridge
Copy link

mlbridge bot commented Apr 23, 2020

Mailing list message from Robin Westberg on skara-dev:

Changeset: 0c38106
Author: Robin Westberg <rwestberg at openjdk.org>
Date: 2020-04-23 04:49:37 +0000
URL: https://git.openjdk.java.net/skara/commit/0c381067

Python 3 compatibility for mercurial extension

Reviewed-by: ehelin

! skara.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants