Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

438: Add "git pr issue" subcommand #684

Closed
wants to merge 2 commits into from
Closed

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Jul 1, 2020

Hi all,

please review this patch that adds the git pr issue subcommand (corresponding
to the /issue pull request command). A user can now run e.g. git pr issue --add=SKARA-419 instead of the pull request command /issue add SKARA-419.

Testing:

  • Manual testing of Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/684/head:pull/684
$ git checkout pull/684

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 1, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@edvbld
Copy link
Member Author

@edvbld edvbld commented Jul 1, 2020

/issue add 438

@openjdk openjdk bot changed the title Add git pr issue 438: Add "git pr issue" subcommand Jul 1, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2020

@edvbld The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 1, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good, just one thing that probably should be changed. :)

cli/src/main/java/org/openjdk/skara/cli/pr/GitPrIssue.java Outdated Show resolved Hide resolved
@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

438: Add "git pr issue" subcommand

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • dbc8501: 434: Adding a contributor without a full name gives a NPE
  • 95d655d: 330: Allow commands at end of PR body

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate dbc85017a5391730baf2711fa6bdc9980841fcf4.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 1, 2020
Co-authored-by: Robin Westberg <robin@westberg.se>
@edvbld
Copy link
Member Author

@edvbld edvbld commented Jul 1, 2020

/integrate

@openjdk openjdk bot closed this Jul 1, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 1, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Jul 1, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • dbc8501: 434: Adding a contributor without a full name gives a NPE
  • 95d655d: 330: Allow commands at end of PR body

Your commit was automatically rebased without conflicts.

Pushed as commit f72f00a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants