Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update jdk.json #747

Closed
wants to merge 1 commit into from
Closed

Update jdk.json #747

wants to merge 1 commit into from

Conversation

@wangweij
Copy link
Contributor

@wangweij wangweij commented Aug 27, 2020

Add two lines and expand one.


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/747/head:pull/747
$ git checkout pull/747

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 27, 2020

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@openjdk openjdk bot added the rfr label Aug 27, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 27, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Thanks for the update!

@openjdk
Copy link

@openjdk openjdk bot commented Aug 28, 2020

@wangweij This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

Update jdk.json

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 13 commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 59448e7253876edb9e1856c2b3467a76fea822f2.

As you do not have Committer status in this project, an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rwestberg) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Aug 28, 2020
@wangweij
Copy link
Contributor Author

@wangweij wangweij commented Sep 1, 2020

/integrate

@openjdk openjdk bot added the sponsor label Sep 1, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 1, 2020

@wangweij
Your change (at version 063121d) is now ready to be sponsored by a Committer.

@rwestberg
Copy link
Member

@rwestberg rwestberg commented Sep 1, 2020

/sponsor

@openjdk openjdk bot closed this Sep 1, 2020
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Sep 1, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 1, 2020

@rwestberg @wangweij The following commits have been pushed to master since your change was applied:

  • 59448e7: storage: support nested paths in file storage
  • 931a0b1: checkout-bot: remote leading slash from path
  • 159f939: 448: Rerun check after updating title
  • cca94e0: 265: Mail bot shows wrong source line for inline review comments
  • b007595: 439: Improve command filtering when bridging mails
  • e36b503: prbot: Allow overriding jcheck configuration
  • b028725: webrev: not all commits changes files
  • 0e4356a: tester: allow configurable allowlist
  • 8a7eb77: vcs: make follow work with merge commits
  • e954044: git-pr-create: be explicit about CC:d mailing lists
  • e3aa0f1: mlrules: applying off-list suggestions
  • 92a9799: Updates to config/mailinglist/rules/jdk.json related to compiler-dev and kulla-dev.
  • aca3439: 542: Adjust label (cc) command logic

Your commit was automatically rebased without conflicts.

Pushed as commit d533135.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.