New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
git-pr-create: be explicit about CC:d mailing lists #750
Conversation
👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type
Since the source branch of this PR was last updated there have been 2 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
/integrate |
@edvbld The following commits have been pushed to master since your change was applied:
Your commit was automatically rebased without conflicts. Pushed as commit e954044. |
Hi all,
please review this patch that makes
git pr create
much more explicit about themailing lists that will be CC:d for the "RFR" email generated from a pull
request. A user can now manually specify the mailing lists with
--cc
flag, forexample:
Furthermore,
git pr create
will now also prompt the user for confirmationabout the selected mailing lists before proceeding:
If a user does not specify
--cc
, thengit pr create
will display the mailinglists that were inferred based on the changes in the pull request:
If a user specify
--cc=auto
then no prompt will be shown and inferred mailinglists will be used.
Additionally, the selected mailing lists will also be shown in the users
$EDITOR
when the user writes the pull request message. For example:As with all flags to Skara's CLI commands, a default value can be configured for
the
--cc
flag. This means that users that so wish can opt in to always use theinferred mailing lists by running:
Testing:
Thanks,
Erik
Progress
Reviewers
Download
$ git fetch https://git.openjdk.java.net/skara pull/750/head:pull/750
$ git checkout pull/750