Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-pr-create: be explicit about CC:d mailing lists #750

Closed
wants to merge 3 commits into from

Conversation

edvbld
Copy link
Member

@edvbld edvbld commented Aug 28, 2020

Hi all,

please review this patch that makes git pr create much more explicit about the
mailing lists that will be CC:d for the "RFR" email generated from a pull
request. A user can now manually specify the mailing lists with --cc flag, for
example:

$ git pr create --cc=hotspot-dev,build-dev

Furthermore, git pr create will now also prompt the user for confirmation
about the selected mailing lists before proceeding:

$ git pr create --cc=hotspot-dev,build-dev
You have chosen the following mailing lists to be CC:d for the "RFR" e-mail:
- hotspot-dev@openjdk.java.net
- build-dev@openjdk.java.net

Do you want to proceed with this mailing list selection? [Y/n]:

If a user does not specify --cc, then git pr create will display the mailing
lists that were inferred based on the changes in the pull request:

The following mailing lists will be CC:d for the "RFR" e-mail:
- build-dev@openjdk.java.net

Do you want to proceed with this mailing list selection? [Y/n]:

If a user specify --cc=auto then no prompt will be shown and inferred mailing
lists will be used.

Additionally, the selected mailing lists will also be shown in the users
$EDITOR when the user writes the pull request message. For example:

  <!-- Please enter the pull request message for your changes.                -->
  <!-- The first line will be considered the title, use a blank line to       -->
  <!-- separate the title from the body. Pull requests are required to have   -->
  <!-- a title and a body. An empty message aborts the pull request.          -->
  <!-- These HTML comment lines will be removed automatically.                -->
  <!--                                                                        -->
  <!-- Commits to be included from branch 'update-readme':                    -->
  <!-- - 13be5f30: Update the README                                          -->
  <!--   M  README.md                                                         -->
  <!--                                                                        -->
  <!-- Repository: https://github.com/openjdk/jdk                             -->
  <!-- Branch:     master                                                     -->
  <!--                                                                        -->
  <!-- The following mailing lists will be CC:d for the "RFR" e-mail:         -->
  <!-- - jdk-dev@openjdk.java.net                                             -->

As with all flags to Skara's CLI commands, a default value can be configured for
the --cc flag. This means that users that so wish can opt in to always use the
inferred mailing lists by running:

$ git config --global pr.create.cc auto

Testing:

  • Manual testing on Linux x64

Thanks,
Erik


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/750/head:pull/750
$ git checkout pull/750

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 28, 2020

👋 Welcome back ehelin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 28, 2020

Webrevs

Copy link
Member

@rwestberg rwestberg left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Aug 28, 2020

@edvbld This change now passes all automated pre-integration checks. When the change also fulfills all project specific requirements, type /integrate in a new comment to proceed. After integration, the commit message will be:

git-pr-create: be explicit about CC:d mailing lists

Reviewed-by: rwestberg
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 2 commits pushed to the master branch:

  • e3aa0f1: mlrules: applying off-list suggestions
  • 92a9799: Updates to config/mailinglist/rules/jdk.json related to compiler-dev and kulla-dev.

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate e3aa0f1bc9eff720021aacb5423492c383b7b0a1.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Aug 28, 2020
@edvbld
Copy link
Member Author

@edvbld edvbld commented Aug 29, 2020

/integrate

@openjdk openjdk bot closed this Aug 29, 2020
@openjdk openjdk bot added integrated and removed ready labels Aug 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Aug 29, 2020

@edvbld The following commits have been pushed to master since your change was applied:

  • e3aa0f1: mlrules: applying off-list suggestions
  • 92a9799: Updates to config/mailinglist/rules/jdk.json related to compiler-dev and kulla-dev.

Your commit was automatically rebased without conflicts.

Pushed as commit e954044.

@openjdk openjdk bot removed the rfr label Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants