Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

616: Sponsorship information is incorrect. #811

Closed
wants to merge 2 commits into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Sep 9, 2020

In the "this PR requires a sponsor" message, there's no need to display different messages depending on author status, just say that Committer status is required.

Best regards,
Robin


Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Issue

  • SKARA-616: Sponsorship information is incorrect.

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/811/head:pull/811
$ git checkout pull/811

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 9, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 616 616: Sponsorship information is incorrect. Sep 9, 2020
@openjdk openjdk bot added the rfr label Sep 9, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2020

@rwestberg The following label will be automatically applied to this pull request: bots.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the bots label Sep 9, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 9, 2020

Webrevs

}

message.append("an existing [Committer](https://openjdk.java.net/bylaws#committer) must agree to ");
message.append("As you do not have [Committer](https://openjdk.java.net/bylaws#committer) status in this project, ");
Copy link
Member

@edvbld edvbld Sep 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make project a link to the project in https://openjdk.java.net/census ?

edvbld
edvbld approved these changes Sep 9, 2020
Copy link
Member

@edvbld edvbld left a comment

Looks great!

@openjdk
Copy link

@openjdk openjdk bot commented Sep 9, 2020

@rwestberg This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

616: Sponsorship information is incorrect.

Reviewed-by: ehelin
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 4 commits pushed to the master branch:

  • de0ffaa: 634: Refresh PR data between commands in CommandWorkItem
  • fe45ab0: 598: Add test-request label when test request needs approval
  • 985532d: jira: make links() more reliable
  • ab9de3d: 625: Proxy build plugin should work on URLs without scheme

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate de0ffaa7590811cf4d10ba16d1d5de3cf56c5beb.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 9, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Sep 10, 2020

/integrate

@openjdk openjdk bot closed this Sep 10, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 10, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 10, 2020

@rwestberg Since your change was applied there have been 4 commits pushed to the master branch:

  • de0ffaa: 634: Refresh PR data between commands in CommandWorkItem
  • fe45ab0: 598: Add test-request label when test request needs approval
  • 985532d: jira: make links() more reliable
  • ab9de3d: 625: Proxy build plugin should work on URLs without scheme

Your commit was automatically rebased without conflicts.

Pushed as commit 8806fe5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants