New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
616: Sponsorship information is incorrect. #811
Conversation
👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into |
@rwestberg The following label will be automatically applied to this pull request: When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the |
Webrevs
|
} | ||
|
||
message.append("an existing [Committer](https://openjdk.java.net/bylaws#committer) must agree to "); | ||
message.append("As you do not have [Committer](https://openjdk.java.net/bylaws#committer) status in this project, "); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make project
a link to the project in https://openjdk.java.net/census ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@rwestberg This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements After integration, the commit message will be:
Since the source branch of this PR was last updated there have been 4 commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge ➡️ To integrate this PR with the above commit message to the |
/integrate |
@rwestberg Since your change was applied there have been 4 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 8806fe5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
In the "this PR requires a sponsor" message, there's no need to display different messages depending on author status, just say that Committer status is required.
Best regards,
Robin
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/skara pull/811/head:pull/811
$ git checkout pull/811