New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make fetchAll the opposite of pushAll #905
Conversation
👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@rwestberg This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. 🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it. 🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@rwestberg Pushed as commit 975fe28. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
@rwestberg The command |
2 similar comments
@rwestberg The command |
@rwestberg The command |
Since pushAll pushes all refs, rename fetchAll to fetchAllRemotes and create fetchAll that fetches all refs.
Progress
Testing
Reviewers
Download
$ git fetch https://git.openjdk.java.net/skara pull/905/head:pull/905
$ git checkout pull/905