Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

768: Skara bot should prevent attempt to use JBS backport issue ID in PR #944

Closed
wants to merge 1 commit into from
Closed

768: Skara bot should prevent attempt to use JBS backport issue ID in PR #944

wants to merge 1 commit into from

Conversation

rwestberg
Copy link
Member

@rwestberg rwestberg commented Nov 5, 2020 •
edited by openjdk[bot] bot

Check that the issue type is of an allowed type.

Progress

  • Change must not contain extraneous whitespace
  • Change must be properly reviewed

Testing

Linux x64 Windows x64 macOS x64
Build / test ✔️ (1/1 passed) ✔️ (1/1 passed) ⏳ (1/1 running)

Issue

  • SKARA-768: Skara bot should prevent attempt to use JBS backport issue ID in PR

Reviewers

Download

$ git fetch https://git.openjdk.java.net/skara pull/944/head:pull/944
$ git checkout pull/944

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 5, 2020

👋 Welcome back rwestberg! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 768 768: Skara bot should prevent attempt to use JBS backport issue ID in PR Nov 5, 2020
@openjdk openjdk bot added the rfr label Nov 5, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 5, 2020

Webrevs

edvbld
edvbld approved these changes Nov 5, 2020
View changes
Copy link
Member

@edvbld edvbld left a comment

Looks good!

@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2020 •
edited

@rwestberg This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

🔍 One or more changes in this pull request modifies files in areas of the source code that often require two reviewers. Please consider if this is the case for this pull request, and if so, await a second reviewer to approve this pull request before you integrate it.

🌎 Applicable reviewers for one or more changes in this pull request are spread across multiple different time zones. Please consider waiting with integrating this pull request until it has been out for review for at least 24 hours to give all reviewers a chance to review the pull request.

After integration, the commit message for the final commit will be:

768: Skara bot should prevent attempt to use JBS backport issue ID in PR

Reviewed-by: ehelin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 5, 2020
@rwestberg
Copy link
Member Author

@rwestberg rwestberg commented Nov 5, 2020

/integrate

@openjdk openjdk bot closed this Nov 5, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 5, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2020

@rwestberg Pushed as commit 4d7471a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk-notifier bot referenced this issue Nov 5, 2020
@rwestberg
768: Skara bot should prevent attempt to use JBS backport issue ID in PR
4d7471a 
Reviewed-by: ehelin
kevinrushforth
kevinrushforth reviewed Nov 6, 2020
View changes
bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java
@@ -62,6 +62,7 @@
"If in doubt, feel free to delete everything in this edit box first, the bot will restore the progress section as needed.\n-->";
private static final String fullNameWarningMarker = "<!-- PullRequestBot full name warning comment -->";
private static final Pattern BACKPORT_PATTERN = Pattern.compile("<!-- backport ([0-9a-z]{40}) -->");
private final static Set<String> primaryTypes = Set.of("Bug", "New Feature", "Enhancement", "Task", "Sub-task");
Copy link
Member

@kevinrushforth kevinrushforth Nov 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinrushforth kevinrushforth

@edvbld edvbld

Assignees
No one assigned
Labels
integrated
Milestone
No milestone
3 participants
@rwestberg @edvbld @kevinrushforth