Skip to content

Commit

Permalink
8242208: Use Method.getParameterCount where applicable
Browse files Browse the repository at this point in the history
Reviewed-by: redestad, chegar
  • Loading branch information
dreis2211 authored and cl4es committed Apr 6, 2020
1 parent e9adf7b commit 08b9028
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
Expand Up @@ -276,13 +276,13 @@ private static boolean isObjectMethod(Method m) {
switch (m.getName()) {
case "toString":
return (m.getReturnType() == String.class
&& m.getParameterTypes().length == 0);
&& m.getParameterCount() == 0);
case "hashCode":
return (m.getReturnType() == int.class
&& m.getParameterTypes().length == 0);
&& m.getParameterCount() == 0);
case "equals":
return (m.getReturnType() == boolean.class
&& m.getParameterTypes().length == 1
&& m.getParameterCount() == 1
&& m.getParameterTypes()[0] == Object.class);
}
return false;
Expand Down
Expand Up @@ -378,7 +378,7 @@ private Parameter[] synthesizeAllParams() {
private void verifyParameters(final Parameter[] parameters) {
final int mask = Modifier.FINAL | Modifier.SYNTHETIC | Modifier.MANDATED;

if (getParameterTypes().length != parameters.length)
if (getParameterCount() != parameters.length)
throw new MalformedParametersException("Wrong number of parameters in MethodParameters attribute");

for (Parameter parameter : parameters) {
Expand Down
Expand Up @@ -121,7 +121,7 @@ public Method[] run() {
if (Modifier.isPublic(method.getModifiers()) &&
Modifier.isAbstract(method.getModifiers()) &&
!method.isSynthetic()) {
if (method.getParameterTypes().length != 0) {
if (method.getParameterCount() != 0) {
throw new IllegalArgumentException(method + " has params");
}
String name = method.getName();
Expand Down

0 comments on commit 08b9028

Please sign in to comment.