Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256663: [test] Deprecated use of new Double in jshell ImportTest #270

Closed
wants to merge 1 commit into from

Conversation

@RogerRiggs
Copy link
Collaborator

@RogerRiggs RogerRiggs commented Nov 19, 2020

The jep-390 warnings caused a couple of tests to fail.
Suppressing the warnings to re-enable the tests.

/issue 8256667 # test/langtools/tools/javac/lambda/8074381/T8074381a.java
/issue 8256663 # test/langtools/jdk/jshell/ImportTest.java


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux x64 Linux x86 Windows x64 macOS x64
Build (1/5 failed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Build / test (1/1 running)
Test (tier1) (1/9 failed) (4/9 running) ✔️ (9/9 passed)

Failed test tasks

Issues

  • JDK-8256663: [test] Deprecated use of new Double in jshell ImportTest
  • JDK-8256667: [test] Unexpected warnings in javac test T8074381a

Reviewers

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/270/head:pull/270
$ git checkout pull/270

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 19, 2020

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into jep390 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 19, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 19, 2020

@RogerRiggs
Adding additional issue to issue list: 8256667: [test] Unexpected warnings in javac test T8074381a.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 19, 2020

@RogerRiggs This issue is referenced in the PR title - it will now be updated.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 19, 2020

Webrevs

Copy link
Member

@lfoltan lfoltan left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 19, 2020

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8256663: [test] Deprecated use of new Double in jshell ImportTest
8256667: [test] Unexpected warnings in javac test T8074381a

Reviewed-by: lfoltan, mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the jep390 branch:

  • 12f93eb: 8253962: Add @ValueBased to unmodifable Collection implementation classes

Please see this link for an up-to-date comparison between the source branch of this pull request and the jep390 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jep390 branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 19, 2020
@RogerRiggs
Copy link
Collaborator Author

@RogerRiggs RogerRiggs commented Nov 19, 2020

/integrate

@openjdk openjdk bot closed this Nov 19, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 19, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 19, 2020

@RogerRiggs Since your change was applied there has been 1 commit pushed to the jep390 branch:

  • 12f93eb: 8253962: Add @ValueBased to unmodifable Collection implementation classes

Your commit was automatically rebased without conflicts.

Pushed as commit eb31a05.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RogerRiggs RogerRiggs deleted the jep390-tests-8256663 branch Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants