New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8256663: [test] Deprecated use of new Double in jshell ImportTest #270
Conversation
👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into |
@RogerRiggs |
@RogerRiggs This issue is referenced in the PR title - it will now be updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
@RogerRiggs This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@RogerRiggs Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit eb31a05. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The jep-390 warnings caused a couple of tests to fail.
Suppressing the warnings to re-enable the tests.
/issue 8256667 # test/langtools/tools/javac/lambda/8074381/T8074381a.java
/issue 8256663 # test/langtools/jdk/jshell/ImportTest.java
Progress
Testing
Failed test tasks
Issues
Reviewers
Download
$ git fetch https://git.openjdk.java.net/valhalla pull/270/head:pull/270
$ git checkout pull/270