Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257846: [lworld] Separate compilation failure of generic inline class #308

Closed
wants to merge 2 commits into from

Conversation

sadayapalam
Copy link
Collaborator

@sadayapalam sadayapalam commented Jan 18, 2021

Ensure inline constructors appears as constructors rather than as static factory methods to top layers of javac after Signature attribute processing.


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8257846: [lworld] Separate compilation failure of generic inline class

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/308/head:pull/308
$ git checkout pull/308

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 18, 2021

👋 Welcome back sadayapalam! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 18, 2021

@sadayapalam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257846: [lworld] Separate compilation failure of generic inline class

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@sadayapalam
Copy link
Collaborator Author

/integrate

@openjdk openjdk bot closed this Jan 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 18, 2021
@openjdk
Copy link

openjdk bot commented Jan 18, 2021

@sadayapalam Pushed as commit bc6af25.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sadayapalam sadayapalam deleted the JDK-8257846 branch January 18, 2021 09:28
@mlbridge
Copy link

mlbridge bot commented Jan 18, 2021

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant