Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262231: [lworld] C2 compilation fails with assert "user must call transfer_exceptions_into_jvms" #348

Closed
wants to merge 3 commits into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Feb 23, 2021

When running with -XX:PerMethodSpecTrapLimit=0 -XX:PerMethodTrapLimit=0, we hit an assert because the unsafe access intrinsic adds an exception to the GraphKit state but then bails out and therefore does not transfer that exception into the JVMState. In general, we should only modify the graph once we are sure we won't bail out from intrinsification. I've added an assert that catches this even without any VM flags and fixed all affected intrinsics.

Best regards,
Tobias


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8262231: [lworld] C2 compilation fails with assert "user must call transfer_exceptions_into_jvms"

Download

$ git fetch https://git.openjdk.java.net/valhalla pull/348/head:pull/348
$ git checkout pull/348

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 23, 2021

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 23, 2021

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262231: [lworld] C2 compilation fails with assert "user must call transfer_exceptions_into_jvms"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 23, 2021

Webrevs

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Feb 23, 2021

I've removed the assert because it triggers issues in mainline code. Will add the assert back into mainline after fixing issues there.

@TobiHartmann
Copy link
Member Author

@TobiHartmann TobiHartmann commented Feb 24, 2021

/integrate

@openjdk openjdk bot closed this Feb 24, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 24, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 24, 2021

@TobiHartmann Pushed as commit 1816db3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant