8262231: [lworld] C2 compilation fails with assert "user must call transfer_exceptions_into_jvms" #348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running with
-XX:PerMethodSpecTrapLimit=0 -XX:PerMethodTrapLimit=0
, we hit an assert because the unsafe access intrinsic adds an exception to theGraphKit
state but then bails out and therefore does not transfer that exception into theJVMState
. In general, we should only modify the graph once we are sure we won't bail out from intrinsification. I've added an assert that catches this even without any VM flags and fixed all affected intrinsics.Best regards,
Tobias
Progress
Issue
Download
$ git fetch https://git.openjdk.java.net/valhalla pull/348/head:pull/348
$ git checkout pull/348