Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268671: [lworld] Wrong code generated for PrimitiveClass.ref.default #445

Closed
wants to merge 2 commits into from

Conversation

sadayapalam
Copy link
Collaborator

@sadayapalam sadayapalam commented Jun 14, 2021

Lower X.ref.default using aconst_null


Progress

  • Change must not contain extraneous whitespace

Issue

  • JDK-8268671: [lworld] Wrong code generated for PrimitiveClass.ref.default

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/valhalla pull/445/head:pull/445
$ git checkout pull/445

Update a local copy of the PR:
$ git checkout pull/445
$ git pull https://git.openjdk.java.net/valhalla pull/445/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 445

View PR using the GUI difftool:
$ git pr show -t 445

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/valhalla/pull/445.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 14, 2021

👋 Welcome back sadayapalam! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 14, 2021

@sadayapalam This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268671: [lworld] Wrong code generated for PrimitiveClass.ref.default

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

@mlbridge
Copy link

mlbridge bot commented Jun 14, 2021

Webrevs

@jespersm
Copy link
Contributor

jespersm commented Jun 15, 2021

Looks good to me!

@sadayapalam
Copy link
Collaborator Author

sadayapalam commented Jun 15, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Jun 15, 2021

Going to push as commit 6215bc5.

@openjdk openjdk bot closed this Jun 15, 2021
@openjdk openjdk bot added integrated and removed ready labels Jun 15, 2021
@openjdk
Copy link

openjdk bot commented Jun 15, 2021

@sadayapalam Pushed as commit 6215bc5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Jun 15, 2021
@sadayapalam sadayapalam deleted the JDK-8268671 branch Jun 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants