Skip to content

Commit

Permalink
Merge
Browse files Browse the repository at this point in the history
  • Loading branch information
JesperIRL committed Jun 22, 2022
2 parents 3b1ec3e + 6458ebc commit 5b583e4
Show file tree
Hide file tree
Showing 12 changed files with 412 additions and 55 deletions.
7 changes: 6 additions & 1 deletion make/test/JtregNativeJdk.gmk
Expand Up @@ -55,7 +55,9 @@ BUILD_JDK_JTREG_EXECUTABLES_CFLAGS_exeJliLaunchTest := \

# Platform specific setup
ifeq ($(call isTargetOs, windows), true)
BUILD_JDK_JTREG_EXCLUDE += libDirectIO.c libInheritedChannel.c exelauncher.c
BUILD_JDK_JTREG_EXCLUDE += libDirectIO.c libInheritedChannel.c \
libExplicitAttach.c libImplicitAttach.c \
exelauncher.c

WIN_LIB_JAVA := $(SUPPORT_OUTPUTDIR)/native/java.base/libjava/java.lib
BUILD_JDK_JTREG_LIBRARIES_LIBS_libstringPlatformChars := $(WIN_LIB_JAVA)
Expand Down Expand Up @@ -84,6 +86,9 @@ else
BUILD_JDK_JTREG_LIBRARIES_LDFLAGS_libLinkerInvokerUnnamed := $(LIBCXX) -pthread
BUILD_JDK_JTREG_LIBRARIES_LDFLAGS_libLinkerInvokerModule := $(LIBCXX) -pthread
BUILD_JDK_JTREG_LIBRARIES_LDFLAGS_libLoaderLookupInvoker := $(LIBCXX) -pthread
BUILD_JDK_JTREG_LIBRARIES_LIBS_libExplicitAttach := -ljvm
BUILD_JDK_JTREG_LIBRARIES_LDFLAGS_libExplicitAttach := -pthread
BUILD_JDK_JTREG_LIBRARIES_LDFLAGS_libImplicitAttach := -pthread
BUILD_JDK_JTREG_EXCLUDE += exerevokeall.c
ifeq ($(call isTargetOs, linux), true)
BUILD_JDK_JTREG_LIBRARIES_LIBS_libInheritedChannel := -ljava
Expand Down
24 changes: 17 additions & 7 deletions src/hotspot/share/jfr/periodic/sampling/jfrThreadSampler.cpp
Expand Up @@ -35,6 +35,7 @@
#include "jfr/utilities/jfrTime.hpp"
#include "jfrfiles/jfrEventClasses.hpp"
#include "logging/log.hpp"
#include "runtime/atomic.hpp"
#include "runtime/frame.inline.hpp"
#include "runtime/javaThread.inline.hpp"
#include "runtime/os.hpp"
Expand Down Expand Up @@ -353,8 +354,8 @@ class JfrThreadSampler : public NonJavaThread {
void run();
static Monitor* transition_block() { return JfrThreadSampler_lock; }
static void on_javathread_suspend(JavaThread* thread);
int64_t get_java_period() const { return _java_period_millis; };
int64_t get_native_period() const { return _native_period_millis; };
int64_t get_java_period() const { return Atomic::load(&_java_period_millis); };
int64_t get_native_period() const { return Atomic::load(&_native_period_millis); };
};

static void clear_transition_block(JavaThread* jt) {
Expand Down Expand Up @@ -417,12 +418,12 @@ JfrThreadSampler::~JfrThreadSampler() {

void JfrThreadSampler::set_java_period(int64_t period_millis) {
assert(period_millis >= 0, "invariant");
_java_period_millis = period_millis;
Atomic::store(&_java_period_millis, period_millis);
}

void JfrThreadSampler::set_native_period(int64_t period_millis) {
assert(period_millis >= 0, "invariant");
_native_period_millis = period_millis;
Atomic::store(&_native_period_millis, period_millis);
}

static inline bool is_released(JavaThread* jt) {
Expand Down Expand Up @@ -501,8 +502,17 @@ void JfrThreadSampler::run() {
last_native_ms = last_java_ms;
}
_sample.signal();
const int64_t java_period_millis = _java_period_millis == 0 ? max_jlong : MAX2<int64_t>(_java_period_millis, 1);
const int64_t native_period_millis = _native_period_millis == 0 ? max_jlong : MAX2<int64_t>(_native_period_millis, 1);

int64_t java_period_millis = get_java_period();
java_period_millis = java_period_millis == 0 ? max_jlong : MAX2<int64_t>(java_period_millis, 1);
int64_t native_period_millis = get_native_period();
native_period_millis = native_period_millis == 0 ? max_jlong : MAX2<int64_t>(native_period_millis, 1);

// If both periods are max_jlong, it implies the sampler is in the process of
// disenrolling. Loop back for graceful disenroll by means of the semaphore.
if (java_period_millis == max_jlong && native_period_millis == max_jlong) {
continue;
}

const int64_t now_ms = get_monotonic_ms();

Expand All @@ -521,7 +531,7 @@ void JfrThreadSampler::run() {
const int64_t sleep_to_next = MIN2<int64_t>(next_j, next_n);

if (sleep_to_next > 0) {
os::naked_short_sleep(sleep_to_next);
os::naked_sleep(sleep_to_next);
}

if ((next_j - sleep_to_next) <= 0) {
Expand Down
67 changes: 30 additions & 37 deletions src/java.base/share/classes/java/lang/Thread.java
Expand Up @@ -652,43 +652,48 @@ private static ClassLoader contextClassLoader(Thread parent) {
@SuppressWarnings("removal")
Thread(ThreadGroup g, String name, int characteristics, Runnable task,
long stackSize, AccessControlContext acc) {
if (name == null) {
throw new InternalError("name cannot be null");
}

Thread parent = currentThread();
boolean attached = (parent == this); // primordial or JNI attached
if (attached && g == null) {
throw new InternalError("group cannot be null when attaching");
}

SecurityManager security = System.getSecurityManager();
if (g == null) {
// the security manager can choose the thread group
if (security != null) {
g = security.getThreadGroup();
if (attached) {
if (g == null) {
throw new InternalError("group cannot be null when attaching");
}

// default to current thread's group
this.holder = new FieldHolder(g, task, stackSize, NORM_PRIORITY, false);
} else {
SecurityManager sm = System.getSecurityManager();
if (g == null) {
g = parent.getThreadGroup();
// the security manager can choose the thread group
if (sm != null) {
g = sm.getThreadGroup();
}

// default to current thread's group
if (g == null) {
g = parent.getThreadGroup();
}
}
}

// permission checks when creating a child Thread
if (!attached && security != null) {
security.checkAccess(g);
if (isCCLOverridden(getClass())) {
security.checkPermission(SecurityConstants.SUBCLASS_IMPLEMENTATION_PERMISSION);
// permission checks when creating a child Thread
if (sm != null) {
sm.checkAccess(g);
if (isCCLOverridden(getClass())) {
sm.checkPermission(SecurityConstants.SUBCLASS_IMPLEMENTATION_PERMISSION);
}
}

int priority = Math.min(parent.getPriority(), g.getMaxPriority());
this.holder = new FieldHolder(g, task, stackSize, priority, parent.isDaemon());
}

if (attached && VM.initLevel() < 1) {
this.tid = 1; // primordial thread
} else {
this.tid = ThreadIdentifiers.next();
}
this.name = name;
this.name = (name != null) ? name : genThreadName();

if (acc != null) {
this.inheritedAccessControlContext = acc;
} else {
Expand Down Expand Up @@ -720,18 +725,6 @@ private static ClassLoader contextClassLoader(Thread parent) {
this.contextClassLoader = ClassLoader.getSystemClassLoader();
}
}

int priority;
boolean daemon;
if (attached) {
// primordial or attached thread
priority = NORM_PRIORITY;
daemon = false;
} else {
priority = Math.min(parent.getPriority(), g.getMaxPriority());
daemon = parent.isDaemon();
}
this.holder = new FieldHolder(g, task, stackSize, priority, daemon);
}

/**
Expand Down Expand Up @@ -1153,7 +1146,7 @@ private static String checkName(String name) {
* @see <a href="#inheritance">Inheritance when creating threads</a>
*/
public Thread() {
this(null, genThreadName(), 0, null, 0, null);
this(null, null, 0, null, 0, null);
}

/**
Expand All @@ -1174,7 +1167,7 @@ public Thread() {
* @see <a href="#inheritance">Inheritance when creating threads</a>
*/
public Thread(Runnable task) {
this(null, genThreadName(), 0, task, 0, null);
this(null, null, 0, task, 0, null);
}

/**
Expand All @@ -1183,7 +1176,7 @@ public Thread(Runnable task) {
* This is not a public constructor.
*/
Thread(Runnable task, @SuppressWarnings("removal") AccessControlContext acc) {
this(null, genThreadName(), 0, task, 0, acc);
this(null, null, 0, task, 0, acc);
}

/**
Expand Down Expand Up @@ -1216,7 +1209,7 @@ public Thread(Runnable task) {
* @see <a href="#inheritance">Inheritance when creating threads</a>
*/
public Thread(ThreadGroup group, Runnable task) {
this(group, genThreadName(), 0, task, 0, null);
this(group, null, 0, task, 0, null);
}

/**
Expand Down
Expand Up @@ -39,27 +39,27 @@
* <li><strong>Document Type Definition (DTD)</strong>
* - XML's built-in schema language.
* </li>
* <li><strong><a href="http://www.w3.org/XML/Schema">W3C XML Schema (WXS)</a></strong> -
* <li><strong><a href="https://www.w3.org/XML/Schema">W3C XML Schema (WXS)</a></strong> -
* an object-oriented XML schema language. WXS also provides a type system
* for constraining the character data of an XML document. WXS is maintained
* by the <a href="http://www.w3.org">World Wide Web Consortium (W3C)</a>
* by the <a href="https://www.w3.org">World Wide Web Consortium (W3C)</a>
* and is a W3C Recommendation (that is, a ratified W3C standard specification).
* </li>
* <li><strong><a href="http://www.relaxng.org">RELAX NG (RNG)</a></strong> -
* <li><strong><a href="https://relaxng.org/">RELAX NG (RNG)</a></strong> -
* a pattern-based, user-friendly XML schema language. RNG schemas may
* also use types to constrain XML character data. RNG is maintained by
* the <a href="http://www.oasis-open.org">Organization for the Advancement
* the <a href="https://www.oasis-open.org">Organization for the Advancement
* of Structured Information Standards (OASIS)</a> and is both an OASIS
* and an <a href="http://www.iso.org">ISO (International Organization
* and an <a href="https://www.iso.org/home.html">ISO (International Organization
* for Standardization)</a> standard.
* </li>
* <li><strong><a href="http://standards.iso.org/ittf/PubliclyAvailableStandards/c055982_ISO_IEC_19757-3_2016.zip">Schematron</a></strong> -
* <li><strong><a href="https://standards.iso.org/ittf/PubliclyAvailableStandards/c055982_ISO_IEC_19757-3_2016.zip">Schematron</a></strong> -
* a rules-based XML schema language. Whereas DTD, WXS, and RNG are designed
* to express the structure of a content model, Schematron is designed to
* enforce individual rules that are difficult or impossible to express
* with other schema languages. Schematron is intended to supplement a
* schema written in structural schema language such as the aforementioned.
* Schematron is <a href="http://standards.iso.org/ittf/PubliclyAvailableStandards/index.html">an ISO standard</a>.
* Schematron is <a href="https://standards.iso.org/ittf/PubliclyAvailableStandards/index.html">an ISO standard</a>.
* </li>
* </ul>
* <p>
Expand Down
Expand Up @@ -27,7 +27,6 @@
/**
* Thrown when a structure violation is detected.
*
* @see StructuredTaskScope#fork(Callable)
* @see StructuredTaskScope#close()
*
* @since 19
Expand Down
2 changes: 2 additions & 0 deletions test/hotspot/jtreg/ProblemList-Xcomp.txt
Expand Up @@ -38,3 +38,5 @@ vmTestbase/nsk/jvmti/scenarios/sampling/SP07/sp07t002/TestDescription.java 82456
vmTestbase/vm/mlvm/mixed/stress/regression/b6969574/INDIFY_Test.java 8265295 linux-x64,windows-x64

serviceability/jvmti/VMObjectAlloc/VMObjectAllocTest.java 8288430 generic-all

serviceability/jvmti/vthread/ContStackDepthTest/ContStackDepthTest.java 8288949 generic-all
70 changes: 70 additions & 0 deletions test/jdk/java/lang/Thread/jni/AttachCurrentThread/AttachTest.java
@@ -0,0 +1,70 @@
/*
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

/**
* @test
* @bug 8287982
* @summary Test native threads attaching to the VM with JNI AttachCurrentThread
* @requires (os.family == "linux" | os.family == "mac")
* @library /test/lib
* @compile ExplicitAttach.java
* @run main AttachTest ExplicitAttach 1
* @run main AttachTest ExplicitAttach 2
* @run main AttachTest ExplicitAttach 4
*/

/**
* @test
* @summary Test native threads attaching implicitly to the VM by means of an upcall
* @requires (os.family == "linux" | os.family == "mac") & (sun.arch.data.model == "64")
* @library /test/lib
* @compile --enable-preview -source ${jdk.version} ImplicitAttach.java
* @run main AttachTest --enable-preview --enable-native-access=ALL-UNNAMED ImplicitAttach 1
* @run main AttachTest --enable-preview --enable-native-access=ALL-UNNAMED ImplicitAttach 2
* @run main AttachTest --enable-preview --enable-native-access=ALL-UNNAMED ImplicitAttach 4
*/

import java.util.stream.Stream;
import jdk.test.lib.process.ProcessTools;
import jdk.test.lib.process.OutputAnalyzer;

public class AttachTest {
static final String TEST_CLASSES = System.getProperty("test.classes");
static final String JAVA_LIBRARY_PATH = System.getProperty("java.library.path");

public static void main(String[] args) throws Exception {
// prepend -cp ${test.classes} -Djava.library.path=${java.library.path}
String[] opts = Stream.concat(Stream.of(
"-cp", TEST_CLASSES,
"-Djava.library.path=" + JAVA_LIBRARY_PATH),
Stream.of(args))
.toArray(String[]::new);
OutputAnalyzer outputAnalyzer = ProcessTools
.executeTestJava(opts)
.outputTo(System.out)
.errorTo(System.out);
int exitValue = outputAnalyzer.getExitValue();
if (exitValue != 0)
throw new RuntimeException("Test failed");
}
}
@@ -0,0 +1,62 @@
/*
* Copyright (c) 2022, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/

import java.util.concurrent.CountDownLatch;

/**
* Test native threads attaching to the VM with JNI AttachCurrentThread.
*/
public class ExplicitAttach {
private static volatile CountDownLatch latch;

public static void main(String[] args) throws Exception {
int threadCount;
if (args.length > 0) {
threadCount = Integer.parseInt(args[0]);
} else {
threadCount = 2;
}
latch = new CountDownLatch(threadCount);

// start the threads and wait for the threads to call home
startThreads(threadCount);
latch.await();
}

/**
* Invoked by attached threads.
*/
private static void callback() {
System.out.println(Thread.currentThread());
latch.countDown();
}

/**
* Start n native threads that attach to the VM and invoke callback.
*/
private static native void startThreads(int n);

static {
System.loadLibrary("ExplicitAttach");
}
}

0 comments on commit 5b583e4

Please sign in to comment.