Update moduleplugin to v1.8.10 #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updating module plugin, to fix issues with newer gradle versions
FlorianKirmaier
changed the title
|
Can someone take a look at this? This is kind of an important fix |
abhinayagarwal
changed the title
abhinayagarwal
approved these changes
Feb 3, 2022
There was a problem hiding this comment.
Tested with Gradle 7.3 and Java 17. Seems to fix the issue while still keeping compatibility with Java 11 👍
|
Thanks for merging. |
|
Now available with v0.0.12 🎉 |
usta
added a commit
to usta/openjfx-docs
that referenced
this pull request
Mar 15, 2022
* Need to increase javafxplugin version because of a bug exist for build with java11+ in moduleplugin which used in older versions of javafxplugin. It is fixed by openjfx/javafx-gradle-plugin#120 Which in merged with 0.0.12 * Need to increase jlink because of a bug exist in jlink for building java16 versions ( beryx/badass-jlink-plugin#176 )
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating module plugin, to fix issues with newer Gradle versions and Java17.
The issue is also described here:
https://discuss.gradle.org/t/unable-to-build-project-with-gradle-7-3-1-on-java-17/41601
and here
java9-modularity/gradle-modules-plugin#199