Skip to content
This repository has been archived by the owner on May 24, 2021. It is now read-only.

Submission Pulldown for Selection of Article Type #1

Closed
katyhuff opened this issue Jul 13, 2017 · 7 comments
Closed

Submission Pulldown for Selection of Article Type #1

katyhuff opened this issue Jul 13, 2017 · 7 comments

Comments

@katyhuff
Copy link
Member

The authors will need to self-identify which type of article they are submitting (lesson material, or software). We'll need to add that to the submission form so that the bot can pull up the proper review checklist.

@labarba
Copy link
Member

labarba commented Jul 21, 2017

This is two tasks:

  1. adding the drop-down "Submission Type" to the web form (easy task)
  2. modifying whedon so it knows which review checklist to print on the "Review" issue (not so easy?)

Perhaps task 2 can be made easier by delegating to the editor that commands whedon to start the review with choosing the submission type. Something like:

@whedon start review -type oer magic-word=bananas
vs
@whedon start review -type tool magic-word=bananas

Leaves a margin for human error, but a minor risk I think.

@labarba
Copy link
Member

labarba commented Jul 21, 2017

@arfon Care to comment on this?

@arfon
Copy link
Member

arfon commented Jul 21, 2017

@arfon Care to comment on this?

Sure thing. I don't think Whedon needs to know anything about this as the review checklist is actually described in the JOSS (or JOSE in this case) we application: https://github.com/openjournals/jose/blob/master/app/views/shared/review_body.erb

So we need to adapt the database schema to add a submission_type field to thepapers table. Then we can add some view logic to allow people to pick which type of material they're submitting.

When the editor starts the review (@whedon start review) we can just have a case statement in the review_body.erb to make sure the correct review body is written to the GitHub issue.

Edit: Do you have someone to make these changes?

@labarba
Copy link
Member

labarba commented Jul 21, 2017

Ah, much better!

@moorepants
Copy link
Member

Do you have someone to make these changes?

I think we need an editor that knows Ruby...

@labarba
Copy link
Member

labarba commented Aug 1, 2017

@arfon : We do not have anyone on hand to make these changes.

@labarba
Copy link
Member

labarba commented Jul 16, 2018

This was completed as part of the whedon upgrade. See:
openjournals/joss#329

@labarba labarba closed this as completed Jul 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants