Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: The Data Behind Dark Matter: Exploring Galactic Rotation #177

Closed
whedon opened this issue Jun 21, 2022 · 34 comments
Closed

[PRE REVIEW]: The Data Behind Dark Matter: Exploring Galactic Rotation #177

whedon opened this issue Jun 21, 2022 · 34 comments

Comments

@whedon
Copy link

whedon commented Jun 21, 2022

Submitting author: @villaa (Anthony Villano)
Repository: https://github.com/villano-lab/galactic-spin-W1
Version: v3.0.0
Editor: @moorepants
Reviewers: @Carreau, @noelstoj
Managing EiC: Jordan Gorzalski

⚠️ JOSE reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSE is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://jose.theoj.org/papers/9fc3443a7c138ea1a3e1a15f4a3f14df"><img src="https://jose.theoj.org/papers/9fc3443a7c138ea1a3e1a15f4a3f14df/status.svg"></a>
Markdown: [![status](https://jose.theoj.org/papers/9fc3443a7c138ea1a3e1a15f4a3f14df/status.svg)](https://jose.theoj.org/papers/9fc3443a7c138ea1a3e1a15f4a3f14df)

Author instructions

Thanks for submitting your paper to JOSE @villaa. Currently, there isn't an JOSE editor assigned to your paper.

@villaa if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSE and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSE submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jun 21, 2022

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSE reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSE is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jun 21, 2022

Wordcount for paper.md is 1184

@whedon
Copy link
Author

whedon commented Jun 21, 2022

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.08 s (664.3 files/s, 123207.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          13            463            596           1608
Jupyter Notebook                10              0           4263            839
TeX                              2             41              0            497
Markdown                        11            133              0            488
reStructuredText                 9            143            175            210
YAML                             5             10             22            102
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                            52            802           5064           3779
-------------------------------------------------------------------------------


Statistical information for the repository '9b614726eae1efae70c907ae' was
gathered on 2022/06/21.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Judit Bergfalk                  24          1421           4188           47.81
Kitty                           11           151             69            1.88
Kitty Harris                     2             5              5            0.09
Raphael Hatami                  12          5612            281           50.23

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Judit Bergfalk              972           68.4          4.7               18.83
Kitty                        84           55.6          3.6               39.29
Raphael Hatami             1611           28.7          0.0               23.59

@whedon
Copy link
Author

whedon commented Jun 21, 2022

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@whedon
Copy link
Author

whedon commented Jun 21, 2022

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1086/182804 is OK
- 10.1046/j.1365-8711.2003.06165.x is OK
- 10.3847/0004-6256/152/6/157 is OK
- 10.5281/zenodo.5570790 is OK
- 10.1093/mnras/203.3.735 is OK
- 10.1051/0004-6361/201116634 is OK
- 10.1111/j.1365-2966.2008.12837.x is OK
- 10.1111/j.1365-2966.2007.11532.x is OK
- 10.1093/mnras/stv568 is OK
- 10.1086/318767 is OK
- 10.1051/0004-6361/201425339 is OK
- 10.1111/j.1365-2966.2008.13422.x is OK
- 10.1086/505345 is OK
- 10.1086/527543 is OK
- DOI:10.5281/zenodo.6588350 is OK

MISSING DOIs

- 10.5860/choice.35-2173 may be a valid DOI for title: An Introduction to Error Analysis: The Study of Uncertainties in Physical Measurements

INVALID DOIs

- None

@villaa
Copy link

villaa commented Jun 21, 2022

Hi @jgorzalski ! Thanks for the instructions. I've consulted with my co-authors and the list and think that these reviewers may be appropriate:

Ali Ramadhan, Matthias Bussonnier, and Nathan Moore

Some of my co-authors git handles are listed here as I have encouraged them to track this thread and help the paper review where possible.

@nuclearGoblin ; @juditbergfalk ; @joohlz ; @frankie-768

@juditbergfalk
Copy link

@whedon commands

@whedon
Copy link
Author

whedon commented Jun 24, 2022

Here are some things you can ask me to do:

# List Whedon's capabilities
@whedon commands

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Ask Whedon to check the references for missing DOIs
@whedon check references

# Ask Whedon to check repository statistics for the submitted software
@whedon check repository

@juditbergfalk
Copy link

Hello @jgorzalski !
I would like to add Ian Hawke to @villaa 's list of reviewers. Reviewer has astrophysics knowledge.
Thank you

@juditbergfalk
Copy link

@whedon list reviewers

@whedon
Copy link
Author

whedon commented Jul 14, 2022

Here's the current list of reviewers: https://bit.ly/jose-reviewers

@villaa
Copy link

villaa commented Jul 29, 2022

@jgorzalski My team has made some upgrades so we would like to change the review version here to v3.0.0, thanks.

@labarba
Copy link
Member

labarba commented Aug 4, 2022

@whedon invite @moorepants

@whedon
Copy link
Author

whedon commented Aug 4, 2022

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@whedon commands

@labarba
Copy link
Member

labarba commented Aug 4, 2022

@whedon invite @moorepants as editor

@whedon
Copy link
Author

whedon commented Aug 4, 2022

@moorepants has been invited to edit this submission.

@villaa
Copy link

villaa commented Aug 6, 2022

@labarba I don't know if you're able, but please update the review version here to v3.0.0, thanks.

@moorepants
Copy link
Member

@labarba I'm on vacation for the next three weeks. I could pick this up in late August or early September.

@labarba
Copy link
Member

labarba commented Aug 6, 2022

@whedon set v3.0.0 as version

@whedon
Copy link
Author

whedon commented Aug 6, 2022

OK. v3.0.0 is the version.

@labarba
Copy link
Member

labarba commented Aug 6, 2022

👋 @moorepants – Thank you! We are currently short of editors (two out on parental leave), so we'll wait for you here.

@moorepants
Copy link
Member

@whedon assign @moorepants as editor

@whedon
Copy link
Author

whedon commented Sep 6, 2022

OK, the editor is @moorepants

@moorepants
Copy link
Member

@IanHawke, @ali-ramadhan, @ntmoore, and @Carreau would any of you like to review this JOSE submission about an education module for simulating galaxies?

@Carreau
Copy link

Carreau commented Sep 7, 2022

Sure, I can do that.

@moorepants
Copy link
Member

@Carreau Great! Thanks for volunteering. I hope to get 1 more reviewer before we officially start, but feel free to have a look at the paper before then.

@Carreau
Copy link

Carreau commented Sep 7, 2022

Sérsic bulges(Edo Noordermeer,2008),

Missing space before the opening bracket if we compare to other citations – I don't know if the authors want to fix that.

I also see on the repository that the author have packaged everything to be available on Binder – that I have started to play with and would have love to have 15 years ago in my cosmo classes – maybe the author want to say one or two sentence as to whether they feel it is better to have local install for users to retain their work and. have a working environment, or prefer the ease of use of the an ephemeral binder ?

@moorepants
Copy link
Member

@whedon add @Carreau as reviewer

@whedon whedon assigned Carreau and unassigned moorepants Sep 7, 2022
@whedon
Copy link
Author

whedon commented Sep 7, 2022

OK, @Carreau is now a reviewer

@moorepants
Copy link
Member

Ok, I've found a second reviewer. Joel Noel-Storr (@noelstoj) has agreed to review.

@moorepants
Copy link
Member

@whedon add @noelstoj as reviewer

@whedon whedon assigned Carreau and unassigned moorepants and Carreau Sep 13, 2022
@whedon
Copy link
Author

whedon commented Sep 13, 2022

OK, @noelstoj is now a reviewer

@moorepants
Copy link
Member

@whedon start review

@whedon
Copy link
Author

whedon commented Sep 13, 2022

OK, I've started the review over in #184.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants