[REVIEW]: TensorFlow.jl: An Idiomatic Julia Front End for TensorFlow #1002
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @jekbradbury it looks like you're currently assigned as the reviewer for this paper If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews To fix this do the following two things:
For a list of things I can do to help you, just type:
|
|
Accept. Looks good to me. A couple quibbles (that don't block acceptance):
|
@whedon generate pdf |
|
Thanks @jekbradbury, I agree with all your points. I've removed the TPU clause and fixed the table formatting. |
@whedon generate pdf |
@jekbradbury : looks like most/all the issues have been addressed? Is this paper ready to be accepted from your point of view? @malmaud: comments from me:
|
Thanks for these comments!
|
|
@arokem: Yes, the paper's ready to be accepted from my POV. |
@jekbradbury : thank you for the review! @malmaud : the paper is ready to be accepted! To go ahead with the archiving of the paper, please create a DOI for the software (e.g., by tagging a release and uploading it to zenodo.org). Once you have a DOI, we can go ahead with the rest of the process. |
OK, I have a DOI: 10.5281/zenodo.1476107. Thanks @jekbradbury and @arokem for handling the review. |
@whedon set 10.5281/zenodo.1476107 as archive |
OK. 10.5281/zenodo.1476107 is the archive. |
@arfon : I believe this article is ready to go! |
@whedon accept |
|
PDF failed to compile for issue #1002 with the following error: % Total % Received % Xferd Average Speed Time Time Time Current 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 |
@whedon accept |
|
Check final proof If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#42, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true |
|
Here's what you must now do:
Any issues? notify your editorial technical team... |
@jekbradbury - many thanks for your review here and to @arokem for editing this submission @malmaud - your paper is now accepted into JOSS and your DOI is https://doi.org/10.21105/joss.01002 |
If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Cool, nice. |
@arokem I was sharing a link around to the released paper,
What should we do? |
@oxinabox - feel free to update your paper in Once you're happy with the changes, I can update the final accepted version. |
Excellent. |
@whedon generate pdf |
|
Paper compilation is failing for some reason right now. I've compiled locally: 10.21105.joss.01002.pdf |
@whedon generate pdf |
|
@oxinabox does it look correct here? https://doi.org/10.21105/joss.01002 |
It seems it does not quiet have the last fixes in |
OK, I've just regenerated (and updated) the live paper. |
Awesome, thanks. |
Submitting author: @malmaud (Jonathan Matthew Malmaud)
Repository: https://github.com/malmaud/TensorFlow.jl
Version: v0.10.1
Editor: @arokem
Reviewer: @jekbradbury
Archive: 10.5281/zenodo.1476107
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@jekbradbury, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @arokem know.
Review checklist for @jekbradbury
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: