Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: UTDEventData: An R package to access political event data #1319

Closed
whedon opened this issue Mar 14, 2019 · 19 comments
Closed

[PRE REVIEW]: UTDEventData: An R package to access political event data #1319

whedon opened this issue Mar 14, 2019 · 19 comments

Comments

@whedon
Copy link

whedon commented Mar 14, 2019

Submitting author: @KateHyoung (Hyoungah Kim)
Repository: https://github.com/KateHyoung/UTDEventData
Version: v1.0.0
Editor: @alexhanna
Reviewers: @briatte, @andrewheiss

Author instructions

Thanks for submitting your paper to JOSS @KateHyoung. Currently, there isn't an JOSS editor assigned to your paper.

@KateHyoung if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Mar 14, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Mar 14, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Mar 14, 2019

PDF failed to compile for issue #1319 with the following error:

ORCID looks to be the wrong length
/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-01ece1d1d135/lib/whedon.rb:91:in block in check_orcids': Problem with ORCID (000-0002-9300-1576) for Latifur Khan (RuntimeError) from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-01ece1d1d135/lib/whedon.rb:89:in each'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-01ece1d1d135/lib/whedon.rb:89:in check_orcids' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-01ece1d1d135/lib/whedon.rb:70:in initialize'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-01ece1d1d135/lib/whedon/processor.rb:32:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-01ece1d1d135/lib/whedon/processor.rb:32:in set_paper'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-01ece1d1d135/bin/whedon:55:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-01ece1d1d135/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@arfon
Copy link
Member

arfon commented Mar 14, 2019

👋 @KateHyoung - it looks like one of the ORCIDs is missing a 0 here?

@arfon
Copy link
Member

arfon commented Mar 14, 2019

@openjournals/joss-eics - the submitting author suggested @arokem as the handling editor.

@KateHyoung
Copy link

Thank you, @arfon, I have fixed it.

@KateHyoung
Copy link

As following @whedon recommendations, here is a list of potential reviewers

@briatte
Copy link

briatte commented Mar 14, 2019

@KateHyoung Would be happy to review (and learn how reviewing for JOSS works in practice, by the same occasion)!

@andrewheiss
Copy link

I'm also fine reviewing!

@alexhanna
Copy link

Happy to see this in submission!

@labarba
Copy link
Member

labarba commented Mar 14, 2019

Since we already have two volunteers willing to contribute a review, I'll assign @alexhanna to handle as editor. Thanks everybody!

@labarba
Copy link
Member

labarba commented Mar 14, 2019

@whedon assign @alexhanna as editor

@whedon
Copy link
Author

whedon commented Mar 14, 2019

OK, the editor is @alexhanna

@labarba
Copy link
Member

labarba commented Mar 14, 2019

@whedon assign @briatte as reviewer

@whedon whedon assigned alexhanna and unassigned alexhanna Mar 14, 2019
@whedon
Copy link
Author

whedon commented Mar 14, 2019

OK, the reviewer is @briatte

@labarba
Copy link
Member

labarba commented Mar 14, 2019

@whedon add @andrewheiss as reviewer

@whedon whedon assigned alexhanna and andrewheiss and unassigned alexhanna Mar 14, 2019
@whedon
Copy link
Author

whedon commented Mar 14, 2019

OK, @andrewheiss is now a reviewer

@labarba
Copy link
Member

labarba commented Mar 14, 2019

@whedon start review

@whedon
Copy link
Author

whedon commented Mar 14, 2019

OK, I've started the review over in #1322. Feel free to close this issue now!

@labarba labarba closed this as completed Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants