Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: DOENOVA: Simple DOE and ANOVA package for Python 3 #1580

Closed
whedon opened this issue Jul 18, 2019 · 27 comments
Closed

[PRE REVIEW]: DOENOVA: Simple DOE and ANOVA package for Python 3 #1580

whedon opened this issue Jul 18, 2019 · 27 comments

Comments

@whedon
Copy link

whedon commented Jul 18, 2019

Submitting author: @fblavoie (Francis B Lavoie)
Repository: https://github.com/fblavoie/doenova
Version: 0.1.3
Editor: @usethedata
Reviewers: @klmedeiros

Author instructions

Thanks for submitting your paper to JOSS @fblavoie. Currently, there isn't an JOSS editor assigned to your paper.

@fblavoie if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jul 18, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Jul 18, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jul 18, 2019

PDF failed to compile for issue #1580 with the following error:

Can't find any papers to compile :-(

@danielskatz
Copy link

@fblavoie - please change manuscript.md to paper.md to whedon can find it

@danielskatz
Copy link

@mgymrek - would you be willing to edit this submission?

@kyleniemeyer
Copy link

Hi @mgymrek, just another ping—we'd like to assign this submission to you.

@kyleniemeyer
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jul 25, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jul 25, 2019

PDF failed to compile for issue #1580 with the following error:

/app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon/author.rb:58:in block in build_affiliation_string': Problem with affiliations for Francis Lavoie, perhaps the affiliations index need quoting? (RuntimeError) from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon/author.rb:57:in each'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon/author.rb:57:in build_affiliation_string' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon/author.rb:17:in initialize'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon.rb:141:in new' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon.rb:141:in block in parse_authors'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon.rb:138:in each' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon.rb:138:in parse_authors'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon.rb:84:in initialize' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon/processor.rb:36:in new'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/lib/whedon/processor.rb:36:in set_paper' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/bin/whedon:55:in prepare'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-5a9319b684e6/bin/whedon:116:in <top (required)>' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in `

'

@kyleniemeyer
Copy link

Hi @fblavoie, please merge the PR I submitted that attempts to fix some things in your paper: fblavoie/doenova#1

@kyleniemeyer
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Jul 26, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Jul 26, 2019

@labarba
Copy link
Member

labarba commented Jul 29, 2019

👋 @fblavoie — I'm the Associate Editor in Chief this week, and I will be continuing to search for an editor to assign to your submission. But first, I need to ask you to add to the top of your paper:

A summary describing the high-level functionality and purpose of the software for a diverse, non-specialist audience.

(From our Documentation.)

As it is, I (a non-specialist) cannot quite parse what your software does, and that makes it hard for me to identify the right editor. Thanks!

@fblavoie
Copy link

Thanks for the follow-up.
I just added the summary to the paper.
If it can help to find an editor... an important part of the software features perform "basic under-grad" mathematics. People working in mathematics/statistics should be able to understand what the software does.

@labarba
Copy link
Member

labarba commented Aug 1, 2019

@whedon assign @usethedata as editor

@arfon
Copy link
Member

arfon commented Aug 2, 2019

@whedon assign @usethedata as editor

@arfon
Copy link
Member

arfon commented Aug 2, 2019

@whedon assign @usethedata as editor

@whedon
Copy link
Author

whedon commented Aug 2, 2019

OK, the editor is @usethedata

@usethedata
Copy link

@klmedeiros -- would you be willing to review this JOSS submission, as a tool for assisting with design of experiments?

@usethedata
Copy link

@kczimm -- would you be willing to review this JOSS submission, as a tool for assisting with design of experiments?

@klmedeiros
Copy link

@usethedata I'd be happy to, thank you so much for asking. I'll review ASAP.

@usethedata
Copy link

Thanks @klmedeiros . I do need a second reviewer, but since you're willing to get started now, I'll open the review issue up and let you get at it. I can add a second reviewer when we find one.

@usethedata
Copy link

@whedon assign @klmedeiros as reviewer

@whedon whedon assigned klmedeiros and usethedata and unassigned usethedata Aug 27, 2019
@whedon
Copy link
Author

whedon commented Aug 27, 2019

OK, the reviewer is @klmedeiros

@usethedata
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Aug 27, 2019

OK, I've started the review over in #1685. Feel free to close this issue now!

@arfon arfon closed this as completed Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants