Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: deepCR: Cosmic Ray Rejection with Deep Learning #1647

Closed
whedon opened this issue Aug 14, 2019 · 35 comments
Closed

[PRE REVIEW]: deepCR: Cosmic Ray Rejection with Deep Learning #1647

whedon opened this issue Aug 14, 2019 · 35 comments
Assignees
Labels
AAS Papers being published together with a AAS submission pre-review Python TeX

Comments

@whedon
Copy link

whedon commented Aug 14, 2019

Submitting author: @kmzzhang (Keming Zhang)
Repository: https://github.com/profjsb/deepCR
Version: 0.1.5
Editor: @terrytangyuan
Reviewers: @shreyasbapat, @DanielLenz

Author instructions

Thanks for submitting your paper to JOSS @kmzzhang. Currently, there isn't an JOSS editor assigned to your paper.

@kmzzhang if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Aug 14, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Aug 14, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Aug 14, 2019

PDF failed to compile for issue #1647 with the following error:

Could not find bibliography file: paper.bib
Error running filter pandoc-citeproc:
Filter returned error status 1
Looks like we failed to compile the PDF

@danielskatz
Copy link

@kmzzhang - There doesn't seem to be a paper.bib file in your repo

@kmzzhang
Copy link

kmzzhang commented Aug 14, 2019 via email

@danielskatz
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Aug 14, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Aug 14, 2019

@danielskatz
Copy link

There's a misspelled robust near the end of the paper... Please fix it, and then add a new comment here containing @whedon generate pdf to rebuild the paper

@danielskatz
Copy link

👋 @terrytangyuan - would you be willing to review this submission?

@terrytangyuan
Copy link
Member

@whedon assign @terrytangyuan as editor

@whedon
Copy link
Author

whedon commented Aug 14, 2019

OK, the editor is @terrytangyuan

@terrytangyuan
Copy link
Member

Sure, @kmzzhang do you have a list of potentials reviewers in mind? If so, please mention them here.

@kmzzhang
Copy link

kmzzhang commented Aug 14, 2019 via email

@danielskatz
Copy link

I wonder if the path to the image is a problem? @arfon - can you help with this? (since we can't see the generate pdf log to see any error msgs)

@terrytangyuan
Copy link
Member

Hi @nilesh-patil @DanielLenz @shreyasbapat Would you be interested in reviewing this submission?

@shreyasbapat
Copy link

Hi @nilesh-patil @DanielLenz @shreyasbapat Would you be interested in reviewing this submission?

Yes sure! I can :)

@DanielLenz
Copy link

I'd be happy to review in general. However, the work has already been described and published in Zhang & Bloom (2019, submitted to AAS), and will undergo peer review there as well.

@arfon
Copy link
Member

arfon commented Aug 15, 2019

I wonder if the path to the image is a problem? @arfon - can you help with this? (since we can't see the generate pdf log to see any error msgs)

@kmzzhang - can you update the URL of the image to: https://raw.githubusercontent.com/profjsb/deepCR/master/imgs/postage-sm.jpg rather than using the relative path?

I'd be happy to review in general. However, the work has already been described and published in Zhang & Bloom (2019, submitted to AAS), and will undergo peer review there as well.

Also, can you confirm @kmzzhang that this is a joint submission with AAS?

@kmzzhang
Copy link

kmzzhang commented Aug 15, 2019 via email

@danielskatz
Copy link

you probably need to do this on github - doing it by email doesn't quite work

@kmzzhang
Copy link

kmzzhang commented Aug 15, 2019 via email

@arfon
Copy link
Member

arfon commented Aug 15, 2019

Yes, this is a joint submission with AAS.

👍 thanks for confirming.

/ cc @crawfordsm

@arfon arfon added the AAS Papers being published together with a AAS submission label Aug 15, 2019
@terrytangyuan
Copy link
Member

terrytangyuan commented Aug 15, 2019

@kmzzhang Please use Github instead of email for responding in the future since the responses from email is very verbose. Thank you.

@terrytangyuan
Copy link
Member

@whedon assign @shreyasbapat as reviewer

@whedon
Copy link
Author

whedon commented Aug 15, 2019

OK, the reviewer is @shreyasbapat

@terrytangyuan
Copy link
Member

@whedon add @DanielLenz as reviewer

@whedon
Copy link
Author

whedon commented Aug 15, 2019

OK, @DanielLenz is now a reviewer

@terrytangyuan
Copy link
Member

@whedon start review

@kmzzhang
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Aug 15, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Aug 15, 2019

@terrytangyuan
Copy link
Member

@whedon start review

@whedon
Copy link
Author

whedon commented Aug 15, 2019

OK, I've started the review over in #1651. Feel free to close this issue now!

@terrytangyuan
Copy link
Member

@shreyasbapat @DanielLenz Thank you! Look forward to your review in #1651!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AAS Papers being published together with a AAS submission pre-review Python TeX
Projects
None yet
Development

No branches or pull requests

7 participants