Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: Torsional Axisymmetric Core Oscillations Visualiser (TACO-VIS): A python module for animating torsional wave data for fluid planetary cores. #1657

Closed
whedon opened this issue Aug 17, 2019 · 31 comments

Comments

@whedon
Copy link

whedon commented Aug 17, 2019

Submitting author: @sam-greenwood (Sam Greenwood)
Repository: https://github.com/sam-greenwood/taco_vis
Version: v1.0
Editor: @leouieda
Reviewers: @malmans2, @banesullivan

Author instructions

Thanks for submitting your paper to JOSS @sam-greenwood. The JOSS editor @leouieda, will work with you on this issue to find a reviewer for your submission before creating the main review issue.

@sam-greenwood if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Aug 17, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @leouieda it looks like you're currently assigned as the editor for this paper 🎉

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for the assigned editor (@leouieda) to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Aug 17, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon whedon added the Python label Aug 17, 2019
@whedon
Copy link
Author

whedon commented Aug 17, 2019

PDF failed to compile for issue #1657 with the following error:

/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in parse': (tmp/1657/paper/paper.md): mapping values are not allowed in this context at line 2 column 70 (Psych::SyntaxError) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:377:in parse_stream'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:325:in parse' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:252:in load'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:473:in block in load_file' from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in open'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/psych.rb:472:in load_file' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-80a4e9edb5a6/lib/whedon.rb:115:in load_yaml'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-80a4e9edb5a6/lib/whedon.rb:85:in initialize' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-80a4e9edb5a6/lib/whedon/processor.rb:36:in new'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-80a4e9edb5a6/lib/whedon/processor.rb:36:in set_paper' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-80a4e9edb5a6/bin/whedon:55:in prepare'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-80a4e9edb5a6/bin/whedon:116:in <top (required)>' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in `

'

@danielskatz
Copy link

👋 @leouieda - the submitter suggested you as reviewer, and I incorrectly assigned it to you without asking. I apologize and hope this is ok - let me know if it is not.

@danielskatz
Copy link

👋 @sam-greenwood - I think merging sam-greenwood/taco_vis#1 should allow the paper to compile - please enter @whedon generate pdf here as a new comment in this issue to try.

@sam-greenwood
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Aug 19, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Aug 19, 2019

PDF failed to compile for issue #1657 with the following error:

pandoc-citeproc: reference cox2014forward not found
pandoc-citeproc: reference cox2014forward not found
Error producing PDF.
! Text line contains an invalid character.
l.407 ...strong magnetic field within the earth^^V

Looks like we failed to compile the PDF

@sam-greenwood
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Aug 19, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Aug 19, 2019

PDF failed to compile for issue #1657 with the following error:

Error producing PDF.
! Text line contains an invalid character.
l.423 convection and jets in earth^^V

Looks like we failed to compile the PDF

@sam-greenwood
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Aug 19, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Aug 19, 2019

@sam-greenwood
Copy link

👉 Check article proof 📄 👈

Almost, just need to fix the figures

@sam-greenwood
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Aug 19, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Aug 19, 2019

@leouieda
Copy link
Member

@danielskatz no problem, I'd be happy to edit this submission!

@danielskatz
Copy link

@whedon assign @leouieda as editor

@whedon whedon assigned leouieda and unassigned leouieda Aug 20, 2019
@whedon
Copy link
Author

whedon commented Aug 20, 2019

OK, the editor is @leouieda

@leouieda
Copy link
Member

👋 Hi @banesullivan @malmans2 would you be interested in reviewing this submission for JOSS?

@malmans2
Copy link

malmans2 commented Sep 5, 2019

Hi @leouieda, sorry for the late reply, I was traveling. Yes, I would be happy to review this!

@banesullivan
Copy link

banesullivan commented Sep 5, 2019

Hi @leouieda and @sam-greenwood, I’d also be happy to review this submission! It looks like a cool visualization tool and I’d be happy to help this project grow

Sorry for the delayed reply as well... things are a bit hectic right now but I’d love to circle back to this next week and get started where I can!

Sent with GitHawk

@leouieda
Copy link
Member

leouieda commented Sep 9, 2019

@malmans2 @banesullivan no worries about the delay. I really appreciate you taking the time to review! 🚀

@leouieda
Copy link
Member

leouieda commented Sep 9, 2019

@whedon assign @malmans2 as reviewer

@whedon whedon assigned leouieda and malmans2 and unassigned leouieda Sep 9, 2019
@whedon
Copy link
Author

whedon commented Sep 9, 2019

OK, the reviewer is @malmans2

@leouieda
Copy link
Member

leouieda commented Sep 9, 2019

@whedon add @banesullivan as reviewer

@whedon whedon assigned banesullivan and leouieda and unassigned leouieda and malmans2 Sep 9, 2019
@whedon
Copy link
Author

whedon commented Sep 9, 2019

OK, @banesullivan is now a reviewer

@leouieda
Copy link
Member

leouieda commented Sep 9, 2019

@whedon start review

@whedon
Copy link
Author

whedon commented Sep 9, 2019

OK, I've started the review over in #1720. Feel free to close this issue now!

@leouieda leouieda closed this as completed Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants