Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: MiSTree: a Python package for constructing and analysing Minimum Spanning Trees #1690

Closed
whedon opened this issue Aug 29, 2019 · 36 comments

Comments

@whedon
Copy link

whedon commented Aug 29, 2019

Submitting author: @knaidoo29 (Krishna Naidoo)
Repository: https://github.com/knaidoo29/mistree
Version: v1.1
Editor: @xuanxu
Reviewers: @melissawm, @zonca

Author instructions

Thanks for submitting your paper to JOSS @knaidoo29. Currently, there isn't an JOSS editor assigned to your paper.

@knaidoo29 if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Aug 29, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Aug 29, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Aug 29, 2019

@labarba
Copy link
Member

labarba commented Aug 29, 2019

👋 @knaidoo29 — I am the Associate Editor-in-Chief on rotation this week. I'm going to send this back to you for some more work, because the paper does not quite meet our expectations. The paper, as submitted, is very brief and doesn't give enough of a description of the software or its need and uses in research. We don't expect a full article, but we recommend 250–1000 words (your Summary is just under that). These items need to be included:

  • the summary describing high-level functionality and purpose of the software for a diverse, non-specialist audience;
  • a clear statement of need that illustrates the research application of the software (including references to other software meeting similar needs).

TL;DR: the article needs to be improved with more description of how the software works, some examples, and use cases.

@labarba
Copy link
Member

labarba commented Aug 29, 2019

@xuanxu — Could you handle this submission as editor?

@knaidoo29
Copy link

Hi @labarba, thank you for the comments. I am currently working on a significant revision/rewrite of the paper and was wondering (1) what the timescale for edits could be (I am planning to have this ready within a week) and (2) what the process was for resubmitting (would I just need to push my new version of the paper to the software's repository?).

@labarba
Copy link
Member

labarba commented Aug 31, 2019

You can just push your changes to the paper, and let us know here when ready. I'll set a reminder for you.

@labarba
Copy link
Member

labarba commented Aug 31, 2019

@whedon remind @knaidoo29 in one week

@whedon
Copy link
Author

whedon commented Aug 31, 2019

Sorry, I can't set reminders on PRE-REVIEW issues.

@labarba
Copy link
Member

labarba commented Aug 31, 2019

Oops. I just learned that our bot's reminding powers don't work here. We'll just wait for your ping!

@xuanxu
Copy link
Member

xuanxu commented Sep 1, 2019

@whedon assign @xuanxu as editor

@whedon
Copy link
Author

whedon commented Sep 1, 2019

OK, the editor is @xuanxu

@knaidoo29
Copy link

Hi @labarba and @xuanxu just to let you know I've updated the paper and pushed it to the repository. I rewrote it and have added some basic examples.

Note, that I've added a new version of the code (i.e. v1.1) which includes some new functions for binning and plotting the Minimum Spanning Tree statistics. I'm not familiar with how you will review the code but I just wanted to highlight this as I believe I placed v1.0 as the version to be tested.

I look forward to your comments.

@xuanxu
Copy link
Member

xuanxu commented Sep 6, 2019

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Sep 6, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Sep 6, 2019

@xuanxu
Copy link
Member

xuanxu commented Sep 6, 2019

@knaidoo29 great, thanks!
We'll start the review once the reviewers are assigned.

@knaidoo29
Copy link

Hi @xuanxu, I just had a look at the proofs and realised my figures are not there. This was because I had my gitignore set up to ignore png files. The images are now on the repository so if the pdf is regenerated it should appear on it now. Thanks (p.s can I regenerate the PDF or do I have to wait for you to do it?)

@labarba
Copy link
Member

labarba commented Sep 6, 2019

You can also run @whedon generate pdf (as a single line in a separate comment) to compile the proof at any time.

@knaidoo29
Copy link

Great, will try it now

@knaidoo29
Copy link

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Sep 6, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Sep 6, 2019

@xuanxu
Copy link
Member

xuanxu commented Sep 10, 2019

👋 @zonca: would you be willing to review this paper? I think your knowledge of Python and algorithms applied to cosmology makes you a great fit for this submission.

@xuanxu
Copy link
Member

xuanxu commented Sep 10, 2019

👋 @melissawm: would you be willing to review this paper? I think your knowledge of math and Python+Fortran makes you a great fit for this submission.

@melissawm
Copy link

Sure, count me in!

@xuanxu
Copy link
Member

xuanxu commented Sep 10, 2019

@melissawm: great, thanks!
I'm going to assign you now and then I'll start the review issue once I find the second reviewer, stay tuned!

@xuanxu
Copy link
Member

xuanxu commented Sep 10, 2019

@whedon assign @melissawm as reviewer

@whedon whedon assigned melissawm and xuanxu and unassigned xuanxu Sep 10, 2019
@whedon
Copy link
Author

whedon commented Sep 10, 2019

OK, the reviewer is @melissawm

@zonca
Copy link

zonca commented Sep 10, 2019

@xuanxu thanks, yes, I can review this

@xuanxu
Copy link
Member

xuanxu commented Sep 10, 2019

@zonca great, thanks! Let's get this started.

@xuanxu
Copy link
Member

xuanxu commented Sep 10, 2019

@whedon add @zonca as reviewer

@whedon
Copy link
Author

whedon commented Sep 10, 2019

OK, @zonca is now a reviewer

@xuanxu
Copy link
Member

xuanxu commented Sep 10, 2019

@whedon start review

@whedon
Copy link
Author

whedon commented Sep 10, 2019

OK, I've started the review over in #1721. Feel free to close this issue now!

@xuanxu
Copy link
Member

xuanxu commented Sep 10, 2019

@melissawm, @zonca : please head over to #1721 where the review will take place.

@xuanxu xuanxu closed this as completed Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants