New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: MiSTree: a Python package for constructing and analysing Minimum Spanning Trees #1690
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
What happens now? This submission is currently in a You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here. |
|
👋 @knaidoo29 — I am the Associate Editor-in-Chief on rotation this week. I'm going to send this back to you for some more work, because the paper does not quite meet our expectations. The paper, as submitted, is very brief and doesn't give enough of a description of the software or its need and uses in research. We don't expect a full article, but we recommend 250–1000 words (your Summary is just under that). These items need to be included:
TL;DR: the article needs to be improved with more description of how the software works, some examples, and use cases. |
@xuanxu — Could you handle this submission as editor? |
Hi @labarba, thank you for the comments. I am currently working on a significant revision/rewrite of the paper and was wondering (1) what the timescale for edits could be (I am planning to have this ready within a week) and (2) what the process was for resubmitting (would I just need to push my new version of the paper to the software's repository?). |
You can just push your changes to the paper, and let us know here when ready. I'll set a reminder for you. |
@whedon remind @knaidoo29 in one week |
Sorry, I can't set reminders on PRE-REVIEW issues. |
Oops. I just learned that our bot's reminding powers don't work here. We'll just wait for your ping! |
OK, the editor is @xuanxu |
Hi @labarba and @xuanxu just to let you know I've updated the paper and pushed it to the repository. I rewrote it and have added some basic examples. Note, that I've added a new version of the code (i.e. v1.1) which includes some new functions for binning and plotting the Minimum Spanning Tree statistics. I'm not familiar with how you will review the code but I just wanted to highlight this as I believe I placed v1.0 as the version to be tested. I look forward to your comments. |
@whedon generate pdf |
|
@knaidoo29 great, thanks! |
Hi @xuanxu, I just had a look at the proofs and realised my figures are not there. This was because I had my gitignore set up to ignore png files. The images are now on the repository so if the pdf is regenerated it should appear on it now. Thanks (p.s can I regenerate the PDF or do I have to wait for you to do it?) |
You can also run |
Great, will try it now |
@whedon generate pdf |
|
👋 @zonca: would you be willing to review this paper? I think your knowledge of Python and algorithms applied to cosmology makes you a great fit for this submission. |
👋 @melissawm: would you be willing to review this paper? I think your knowledge of math and Python+Fortran makes you a great fit for this submission. |
Sure, count me in! |
@melissawm: great, thanks! |
@whedon assign @melissawm as reviewer |
OK, the reviewer is @melissawm |
@xuanxu thanks, yes, I can review this |
@zonca great, thanks! Let's get this started. |
OK, @zonca is now a reviewer |
@whedon start review |
OK, I've started the review over in #1721. Feel free to close this issue now! |
@melissawm, @zonca : please head over to #1721 where the review will take place. |
Submitting author: @knaidoo29 (Krishna Naidoo)
Repository: https://github.com/knaidoo29/mistree
Version: v1.1
Editor: @xuanxu
Reviewers: @melissawm, @zonca
Author instructions
Thanks for submitting your paper to JOSS @knaidoo29. Currently, there isn't an JOSS editor assigned to your paper.
@knaidoo29 if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:
The text was updated successfully, but these errors were encountered: