New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PRE REVIEW]: RepnDecomp: A GAP package for decomposing linear representations of finite groups #1695
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
What happens now? This submission is currently in a You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here. |
|
PDF failed to compile for issue #1695 with the following error: /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in |
@whedon generate pdf |
|
👋 @VivianePons — the author suggested you as handling editor... are you back from leave? This is right up your alley. |
👋 Hey @labarba... Letting you know, |
That answers my question! Will look for another editor. |
👋 @meg-simula - would you be willing to edit this submission for JOSS? |
Thanks for asking - but this submission is quite outside my area of expertise, so I'm a bit reluctant to jump in. |
OK thanks @meg-simula @kaashif - we have an editor that would be perfect for this submission but she's currently out on maternity leave for the next month. Would it be acceptable to you to wait for a month before moving the submission forward? |
That's fine, there's no rush for me. |
Great. I'll go ahead and assign the editor but also mark the submission as paused for now. Our editor should be back in the ~1 month! |
@whedon assign @VivianePons as editor |
👋 Hey @arfon... Letting you know, |
OK, the editor is @VivianePons |
👋 Hey @whedon... Letting you know, |
Just to register for this thread - I am a co-author of the paper. Somehow the submission procedure does not ping all the co-authors, not sure whether it's a bug or a feature. |
Regarding reviewing of this paper: @alex-konovalov from the list of reviewers would be an obvious choice, but we work at the same department (since the beginning of this month :-)) not sure how this sits w.r.t. journal policies. |
@dimpase in which case we can ask if anyone outside is interested to review it, I will be happy to assist reviewers with checking regression tests. @kaashif could you please adjust the output of the default package test - see diffs in https://travis-ci.org/gap-infra/gap-docker-pkg-tests-master-devel/jobs/584474552 |
👋 I've removed the "paused" label on this, as @VivianePons should be back to editing now. |
@alex-konovalov I would actually like to have you as a reviewer even if you work in the same department as @dimpase. As I know you personally, I trust your judgment! And I will look for a secondary reviewer anyway. |
@VivianePons thanks, will be happy to review then - makes sense, since I run the package update system for GAP and have access to tools for automated checks. We need also to discuss with @dimpase and @kaashif plans for submitting this package for the redistribution with GAP, and perhaps align the two processes. In the meantime, it would be useful if you could fix tests at https://travis-ci.org/gap-infra/gap-docker-pkg-tests-master-devel, address some issues at https://gitlab.com/kaashif/decomp/, and think whether you may want to migrate to https://github.com/gap-packages or establish a proper website on GitLab by adapting https://github.com/gap-system/ReleaseTools and |
@whedon assign @alex-konovalov as reviewer |
OK, the reviewer is @alex-konovalov |
Acknowledged, will work on fixing those tests and issues. I've just started a new job and been quite busy which is why I haven't gotten around to it yet, sorry about that. Also my employer is fairly strict about making sure any software I release doesn't contain any stolen intellectual property or whatever, but that should all be cleared up fairly soon. Migrating to https://github.com/gap-packages seems like a good idea for discoverability, ease of contributions, etc. |
@kaashif thanks. I've invited you to https://github.com/orgs/gap-packages/ and then you should be to migrate the repository. I suggest then to discuss technical details there. |
OK, @falque is now a reviewer |
@whedon start review |
OK, I've started the review over in #1835. Feel free to close this issue now! |
Thanks @VivianePons. I've checked https://github.com/openjournals/joss/blob/master/COI.md - just to confirm with you as an editor, do we agree that I can tick the COI box in the review, since being involved with @dimpase in OpenDreamKit and CoDiMa projects, and being employed at the same institution (since recently) in not a CoI in this particular case? |
Yes, it's ok, it's been "disclosed and waived" |
Submitting author: @kaashif (Kaashif Hymabaccus)
Repository: https://gitlab.com/kaashif/decomp/
Version: 0.1
Editor: @VivianePons
Reviewers: @alex-konovalov, @falque
Author instructions
Thanks for submitting your paper to JOSS @kaashif. Currently, there isn't an JOSS editor assigned to your paper.
@kaashif if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.
Editor instructions
The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:
The text was updated successfully, but these errors were encountered: