Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: RepnDecomp: A GAP package for decomposing linear representations of finite groups #1695

Closed
whedon opened this issue Aug 31, 2019 · 34 comments

Comments

@whedon
Copy link

whedon commented Aug 31, 2019

Submitting author: @kaashif (Kaashif Hymabaccus)
Repository: https://gitlab.com/kaashif/decomp/
Version: 0.1
Editor: @VivianePons
Reviewers: @alex-konovalov, @falque

Author instructions

Thanks for submitting your paper to JOSS @kaashif. Currently, there isn't an JOSS editor assigned to your paper.

@kaashif if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Aug 31, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Aug 31, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Aug 31, 2019

PDF failed to compile for issue #1695 with the following error:

/app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in block in find': No such file or directory - tmp/1695 (Errno::ENOENT) from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in collect!'
from /app/vendor/ruby-2.4.4/lib/ruby/2.4.0/find.rb:43:in find' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-80a4e9edb5a6/lib/whedon/processor.rb:61:in find_paper_paths'
from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-80a4e9edb5a6/bin/whedon:50:in prepare' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/command.rb:27:in run'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in invoke_command' from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor.rb:387:in dispatch'
from /app/vendor/bundle/ruby/2.4.0/gems/thor-0.20.3/lib/thor/base.rb:466:in start' from /app/vendor/bundle/ruby/2.4.0/bundler/gems/whedon-80a4e9edb5a6/bin/whedon:116:in <top (required)>'
from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in load' from /app/vendor/bundle/ruby/2.4.0/bin/whedon:23:in

'

@labarba
Copy link
Member

labarba commented Aug 31, 2019

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Aug 31, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Aug 31, 2019

@labarba
Copy link
Member

labarba commented Aug 31, 2019

👋 @VivianePons — the author suggested you as handling editor... are you back from leave? This is right up your alley.
"RepnDecomp: A GAP package for decomposing linear representations of finite groups"
https://gitlab.com/kaashif/decomp/

@ooo
Copy link

ooo bot commented Aug 31, 2019

👋 Hey @labarba...

Letting you know, @VivianePons is currently OOO until Thursday, October 3rd 2019. ❤️

@labarba
Copy link
Member

labarba commented Aug 31, 2019

That answers my question! Will look for another editor.

@arfon
Copy link
Member

arfon commented Sep 5, 2019

👋 @meg-simula - would you be willing to edit this submission for JOSS?

@meg-simula
Copy link

Thanks for asking - but this submission is quite outside my area of expertise, so I'm a bit reluctant to jump in.

@arfon
Copy link
Member

arfon commented Sep 5, 2019

Thanks for asking - but this submission is quite outside my area of expertise, so I'm a bit reluctant to jump in.

OK thanks @meg-simula

@kaashif - we have an editor that would be perfect for this submission but she's currently out on maternity leave for the next month. Would it be acceptable to you to wait for a month before moving the submission forward?

@kaashif
Copy link

kaashif commented Sep 5, 2019

That's fine, there's no rush for me.

@arfon
Copy link
Member

arfon commented Sep 5, 2019

That's fine, there's no rush for me.

Great. I'll go ahead and assign the editor but also mark the submission as paused for now. Our editor should be back in the ~1 month!

@arfon
Copy link
Member

arfon commented Sep 5, 2019

@whedon assign @VivianePons as editor

@ooo
Copy link

ooo bot commented Sep 5, 2019

👋 Hey @arfon...

Letting you know, @VivianePons is currently OOO until Thursday, October 3rd 2019. ❤️

@whedon
Copy link
Author

whedon commented Sep 5, 2019

OK, the editor is @VivianePons

@ooo
Copy link

ooo bot commented Sep 5, 2019

👋 Hey @whedon...

Letting you know, @VivianePons is currently OOO until Thursday, October 3rd 2019. ❤️

@arfon arfon added the paused label Sep 5, 2019
@dimpase
Copy link

dimpase commented Sep 12, 2019

Just to register for this thread - I am a co-author of the paper. Somehow the submission procedure does not ping all the co-authors, not sure whether it's a bug or a feature.

@dimpase
Copy link

dimpase commented Sep 12, 2019

Regarding reviewing of this paper: @alex-konovalov from the list of reviewers would be an obvious choice, but we work at the same department (since the beginning of this month :-)) not sure how this sits w.r.t. journal policies.

@olexandr-konovalov
Copy link
Member

@dimpase in which case we can ask if anyone outside is interested to review it, I will be happy to assist reviewers with checking regression tests. @kaashif could you please adjust the output of the default package test - see diffs in https://travis-ci.org/gap-infra/gap-docker-pkg-tests-master-devel/jobs/584474552

@labarba labarba removed the paused label Oct 9, 2019
@labarba
Copy link
Member

labarba commented Oct 9, 2019

👋 I've removed the "paused" label on this, as @VivianePons should be back to editing now.

@VivianePons
Copy link

@alex-konovalov I would actually like to have you as a reviewer even if you work in the same department as @dimpase. As I know you personally, I trust your judgment! And I will look for a secondary reviewer anyway.

@olexandr-konovalov
Copy link
Member

@VivianePons thanks, will be happy to review then - makes sense, since I run the package update system for GAP and have access to tools for automated checks. We need also to discuss with @dimpase and @kaashif plans for submitting this package for the redistribution with GAP, and perhaps align the two processes. In the meantime, it would be useful if you could fix tests at https://travis-ci.org/gap-infra/gap-docker-pkg-tests-master-devel, address some issues at https://gitlab.com/kaashif/decomp/, and think whether you may want to migrate to https://github.com/gap-packages or establish a proper website on GitLab by adapting https://github.com/gap-system/ReleaseTools and
https://github.com/gap-system/GitHubPagesForGAP

@VivianePons
Copy link

@whedon assign @alex-konovalov as reviewer

@whedon
Copy link
Author

whedon commented Oct 18, 2019

OK, the reviewer is @alex-konovalov

@kaashif
Copy link

kaashif commented Oct 20, 2019

Acknowledged, will work on fixing those tests and issues. I've just started a new job and been quite busy which is why I haven't gotten around to it yet, sorry about that. Also my employer is fairly strict about making sure any software I release doesn't contain any stolen intellectual property or whatever, but that should all be cleared up fairly soon.

Migrating to https://github.com/gap-packages seems like a good idea for discoverability, ease of contributions, etc.

@olexandr-konovalov
Copy link
Member

@kaashif thanks. I've invited you to https://github.com/orgs/gap-packages/ and then you should be to migrate the repository. I suggest then to discuss technical details there.

@VivianePons
Copy link

@whedon add @falque as reviewer

@whedon
Copy link
Author

whedon commented Oct 24, 2019

OK, @falque is now a reviewer

@VivianePons
Copy link

@whedon start review

@whedon
Copy link
Author

whedon commented Oct 24, 2019

OK, I've started the review over in #1835. Feel free to close this issue now!

@olexandr-konovalov
Copy link
Member

Thanks @VivianePons. I've checked https://github.com/openjournals/joss/blob/master/COI.md - just to confirm with you as an editor, do we agree that I can tick the COI box in the review, since being involved with @dimpase in OpenDreamKit and CoDiMa projects, and being employed at the same institution (since recently) in not a CoI in this particular case?

@VivianePons
Copy link

Yes, it's ok, it's been "disclosed and waived"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants