Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: AliasFinder: A Python script to search for the true planetary frequency within radial velocity data #1767

Closed
whedon opened this issue Sep 26, 2019 · 27 comments

Comments

@whedon
Copy link

whedon commented Sep 26, 2019

Submitting author: @StephanStock (Stephan Stock)
Repository: https://github.com/JonasKemmer/AliasFinder
Version: v1.0.0
Editor: @xuanxu
Reviewers: @Juanlu001, @wtgee

Author instructions

Thanks for submitting your paper to JOSS @StephanStock. Currently, there isn't an JOSS editor assigned to your paper.

@StephanStock if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Sep 26, 2019

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

What happens now?

This submission is currently in a pre-review state which means we are waiting for an editor to be assigned and for them to find some reviewers for your submission. This may take anything between a few hours to a couple of weeks. Thanks for your patience 😸

You can help the editor by looking at this list of potential reviewers to identify individuals who might be able to review your submission (please start at the bottom of the list). Also, feel free to suggest individuals who are not on this list by mentioning their GitHub handles here.

@whedon
Copy link
Author

whedon commented Sep 26, 2019

Attempting PDF compilation. Reticulating splines etc...

@whedon
Copy link
Author

whedon commented Sep 26, 2019

@arfon
Copy link
Member

arfon commented Sep 26, 2019

@StephanStock - this looks to be a duplicate of #1724 which was rejected as being out of scope. Could you clarify why there has been a resubmission?

/ cc @danielskatz

@StephanStock
Copy link

Hello,
as requested in #1724 we implemented the pip install for our software which was the reason why it was rejected. It is now 'designed for maintainable extension'.

/cc @JonasKemmer @xuanxu

@danielskatz
Copy link

👋 @xuanxu - can I ask you to take the lead on making sure this is now suitable, and if so, editing it?

@xuanxu
Copy link
Member

xuanxu commented Sep 27, 2019

@danielskatz yes, I'll edit it.

@xuanxu
Copy link
Member

xuanxu commented Sep 27, 2019

I think in its current form it qualifies as a maintainable research software, so I'm moving this forward

@xuanxu
Copy link
Member

xuanxu commented Sep 27, 2019

👋 @Juanlu001: Are you still willing to review this paper? It is an improved resubmission of #1724

@xuanxu
Copy link
Member

xuanxu commented Sep 27, 2019

@whedon assign @xuanxu as editor

@whedon
Copy link
Author

whedon commented Sep 27, 2019

OK, the editor is @xuanxu

@astrojuanlu
Copy link

Excellent! @xuanxu I will gladly review

@xuanxu
Copy link
Member

xuanxu commented Sep 27, 2019

@Juanlu001 great!, I'll start the review issue once I find the second reviewer, stay tuned!

@xuanxu
Copy link
Member

xuanxu commented Sep 27, 2019

👋 @ygrange - would you be willing to review this submission for JOSS? I think your knowledge of Python and Astronomy makes you a good fit for this submission.

@StephanStock
Copy link

As a potential reviewer we also suggest @nespinoza who also works with Exoplanets

@ygrange
Copy link

ygrange commented Sep 27, 2019

Well, I am pretty busy the coming two weeks at least, so maybe it would be wise to have another reviewer.
If there is no second reviewer and you are willing to wait a few weeks, I can do it though.

@xuanxu
Copy link
Member

xuanxu commented Sep 27, 2019

@ygrange: ok, thanks!, let's see if I can find another reviewer

@xuanxu
Copy link
Member

xuanxu commented Sep 27, 2019

👋 @wtgee - would you be willing to review this submission for JOSS? I think your knowledge of Python and Exoplanets makes you a great fit for this submission.

@wtgee
Copy link

wtgee commented Sep 28, 2019

@xuanxu yes, I have some time to do this. And I like the potential pun on 'fit'. :)

@xuanxu
Copy link
Member

xuanxu commented Sep 28, 2019

@wtgee great, thanks!

@xuanxu
Copy link
Member

xuanxu commented Sep 28, 2019

@whedon add @Juanlu001 as reviewer

@whedon whedon assigned astrojuanlu and unassigned xuanxu Sep 28, 2019
@whedon
Copy link
Author

whedon commented Sep 28, 2019

OK, @Juanlu001 is now a reviewer

@xuanxu
Copy link
Member

xuanxu commented Sep 28, 2019

@whedon add @wtgee as reviewer

@whedon whedon assigned astrojuanlu, wtgee and xuanxu and unassigned xuanxu and astrojuanlu Sep 28, 2019
@whedon
Copy link
Author

whedon commented Sep 28, 2019

OK, @wtgee is now a reviewer

@xuanxu
Copy link
Member

xuanxu commented Sep 28, 2019

@whedon start review

@whedon
Copy link
Author

whedon commented Sep 28, 2019

OK, I've started the review over in #1771. Feel free to close this issue now!

@xuanxu
Copy link
Member

xuanxu commented Sep 28, 2019

@Juanlu001, @wtgee - please head over to #1771 where the review will take place.

@xuanxu xuanxu closed this as completed Sep 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants