New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: GroundwaterDupuitPercolator: A Landlab component for groundwater flow #1935
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @dvalters, @rreinecke it looks like you're currently assigned to review this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
|
|
Just a quick note to reviewers @dvalters, @nicgaspar that this is where the review is to take place. Thanks! |
Happy New Year @dvalters and @nicgaspar! Here is a friendly reminder for your review, maybe in a few days after you have celebrated the new year coming in. Thanks! |
Hi @kthyng! I'm behind as always. I just realized that I have a COI. I am still willing to go ahead with the review if you think it is OK. But I actively collaborate with Katy Barnhart and Greg Tucker, both of whom are co-authors. As in we are working on papers together now, and have published together in the last year. I feel I can be unbiased, but I should let you know. Sorry this took so long. |
@nicgaspar Hm I think that is too close. I will search for a new reviewer. Thank you for pointing this out. |
Hi @rreinecke! You were interested in this JOSS submission before — any chance you still are and are available to review it? It turns out we had a conflict of interest with another reviewer. |
@dvalters What is your timeline for working on this review? Thanks. |
@kthyng Sure. |
@rreinecke Awesome! Thanks. I will add you on. |
@whedon add @rreinecke as reviewer |
OK, @rreinecke is now a reviewer |
@whedon remove @nicgaspar as reviewer |
@DavidLitwin Just read through your paper and have one small typo in the paper #1144 and a few in the bib file #1145. See what you think. After that, let me know: what is the appropriate version number to use? Also, can you set up an archive of your code at, for example, Zenodo, and report back here with the doi? |
@kthyng thank you for the typo corrections. @kbarnhart I want to make sure the version and doi are handled correctly.. If we do it similarly to the JOSS paper for |
Just fixed one other typo in landlab/landlab#1146. |
@DavidLitwin you are correct. the typo you just fixed isn't in v2.0.0b5, but I'm not sure if that is important. if it is, we can make a new release. |
@kbarnhart I think that should be fine, right? @kthyng zenodo seems to be having some trouble right now, but the DOI is 10.5281/zenodo.154179. |
@DavidLitwin I don't think that is the correct DOI. That looks like the DOI for v1.0.1. |
@kbarnhart do you have the correct one? That's the one that appears in the readme for landlab on github, and I can't find anything past 1.5.4 with a DOI on zenodo. |
@DavidLitwin I would manually make a Zenodo archive rather than use the auto-created Zenodo archive that sometimes get made when a new tag is created. I also say this because I know in the JOSS docs there is a statement that the title and authors of the zenodo archive should match. The docs say:
So I think you'll need to download a .zip of the current version of Landlab and archive it with the name and authors of this contribution. I'll let @kthyng chime in if she thinks this is not correct. |
@kbarnhart Yes this sounds correct to me. I haven't gone through the process myself but we do want the relevant version of the code archived at something like Zenodo, and we want the authors/title to match the paper exactly. Having the whole Landlab in the archive does make sense, given this is a submodule. |
@kthyng and @kbarnhart I have created an archive of the latest landlab release (2.0.0b5) here: http://doi.org/10.5281/zenodo.3660698 Please let me know if there are any issues with this and I will try to resolve them. |
@whedon set v2.0.0b5 as version |
OK. v2.0.0b5 is the version. |
@whedon set 10.5281/zenodo.3660698 as archive |
OK. 10.5281/zenodo.3660698 is the archive. |
@whedon accept |
|
|
Check final proof 👉 openjournals/joss-papers#1290 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1290, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? notify your editorial technical team... |
Congratulations to @DavidLitwin on your new publication! Thanks to reviewers @dvalters and @rreinecke for your time and expertise. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @DavidLitwin (David Litwin)
Repository: https://github.com/landlab/landlab
Version: v2.0.0b5
Editor: @kthyng
Reviewers: @dvalters, @rreinecke
Archive: 10.5281/zenodo.3660698
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@dvalters & @rreinecke, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @kthyng know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @dvalters
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @rreinecke
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: