-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: thresholdmodeling: A Python package for modeling excesses over a threshold using the Peak-Over-Threshold Method and the Generalized Pareto Distribution #2013
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @bahung, @kellieotto it looks like you're currently assigned to review this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
I made some minimal corrections in the paper. |
@whedon generate pdf |
Modified paper considering @kellieotto corrections below. |
@whedon generate pdf |
Below, I tried to consider all the changes suggested by @bahung. |
@whedon generate pdf |
@whedon generate pdf |
@whedon generate pdf |
@whedon generate pdf |
@drvinceknight I recommend the package for approval. @iagolemos1 has responded to all of my comments. |
@kellieotto Thanks for the support and to help my paper to get better! |
Thank you @kellieotto, I believe we are no waiting on @bahung to finish their review? |
Version 0.0.1. |
DOI in Zenodo: |
@whedon set 10.5281/zenodo.3661338 as archive |
OK. 10.5281/zenodo.3661338 is the archive. |
@openjournals/joss-eics this paper is now ready to be accepted :) 👍 🎆 Thank you @bahung and @kellieotto for your time and effort reviewing the work. 👍 |
@whedon accept |
|
|
Check final proof 👉 openjournals/joss-papers#1294 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1294, then you can now move forward with accepting the submission by compiling again with the flag
|
👋 @iagolemos1 - please merge iagolemos1/thresholdmodeling#8 or let me know what parts of it you disagree with. Also, there is at least one case error in the .bib file, a pareto that should be {P}areto. Please check the bib entries as built in the pdf carefully, and make any other needed changes as well. |
Hi @danielskatz. I merged the changes and made the changes in the .bib file. Thanks! |
@whedon generate pdf |
@whedon accept |
|
|
Check final proof 👉 openjournals/joss-papers#1295 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1295, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? notify your editorial technical team... |
Thanks to @bahung, @kellieotto for reviewing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
@danielskatz I tried to reach the paper using the DOI and it's appearing "File not foud". It's because the DOI isn't ready yet? |
The link https://doi.org/10.21105/joss.02013 works fine for me (and did before I closed the issue) - it might just be an issue of how new DOIs resolve and how this information is distributed. Please try again in a little bit and if it continue to not work for you, let us know. As I look at this more carefully, the DOI is resolving for you, and bringing you to the right page. The problem you are having is that the PDF at that page is not displaying, which is likely a web caching issue. Again, however, waiting a little bit should work. |
Ok, thanks! |
Submitting author: @iagolemos1 (Iago Lemos)
Repository: https://github.com/iagolemos1/thresholdmodeling
Version: v0.0.1
Editor: @drvinceknight
Reviewer: @bahung, @kellieotto
Archive: 10.5281/zenodo.3661338
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@bahung & @kellieotto, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @drvinceknight know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @bahung
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @kellieotto
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: