Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: OMG: A Scalable and Flexible Simulation and Testing Environment Toolbox for Intelligent Microgrid Control #2256

Closed
whedon opened this issue May 26, 2020 · 49 comments

Comments

@whedon
Copy link

whedon commented May 26, 2020

Submitting author: @stheid (Stefan Heid)
Repository: https://github.com/upb-lea/openmodelica-microgrid-gym
Version: v0.2.0
Editor: @dhhagan
Reviewers: @katyhuff, @gonsie
Managing EiC: Daniel S. Katz

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Author instructions

Thanks for submitting your paper to JOSS @stheid. Currently, there isn't an JOSS editor assigned to your paper.

@stheid if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented May 26, 2020

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented May 26, 2020

Software report (experimental):

github.com/AlDanial/cloc v 1.84  T=0.10 s (738.2 files/s, 46954.6 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          34            629           1006           1467
reStructuredText                33            347            203            678
make                             2             24              7             74
YAML                             1              7              0             39
DOS Batch                        1              8              1             26
-------------------------------------------------------------------------------
SUM:                            71           1015           1217           2284
-------------------------------------------------------------------------------


Statistical information for the repository '2256' was gathered on 2020/05/26.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Daniel Weber                    88          2088           1631           12.38
Stefan Heid                    136         11200          10905           73.59
hbode                           11          2743            837           11.92
walli                            9           387            246            2.11

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Daniel Weber                650           31.1          1.0               17.38
Oliver Wallscheid            94          100.0          0.8               53.19
Stefan Heid                1924           17.2          1.3               10.40
hbode                       434           15.8          0.5               39.86

@whedon
Copy link
Author

whedon commented May 26, 2020

PDF failed to compile for issue #2256 with the following error:

Can't find any papers to compile :-(

@danielskatz
Copy link

👋 @stheid - where is the paper.md and .bib file for this submission?

@stheid
Copy link

stheid commented May 27, 2020

Oh, i assume the issue is caused that the paper is currently not yet on the master branch. The preview worked fine. I am a bit worried about making an ad-hoc merge. Please give me until the end of this work-week to properly finalize our development branch and merge to master.

@stheid
Copy link

stheid commented May 28, 2020

@danielskatz i assume it is fine now. the whedon.theoj preview produces a paper if i omit specifying the branch (meaning master branch)

@stheid
Copy link

stheid commented May 28, 2020

@whedon generate pdf

@whedon
Copy link
Author

whedon commented May 28, 2020

@stheid
Copy link

stheid commented May 28, 2020

image

And is there a way to fix the missing whitespace typo? I assume everything will be automatic from here on so the typo would also be on you website if this review comes to an sucessfull end.

@stheid
Copy link

stheid commented May 28, 2020

@whedon set v0.2.0 as version

@whedon
Copy link
Author

whedon commented May 28, 2020

I'm sorry @stheid, I'm afraid I can't do that. That's something only editors are allowed to do.

@danielskatz danielskatz changed the title [PRE REVIEW]: OMG: A Scalable and Flexible Simulation and TestingEnvironment Toolbox for Intelligent Microgrid Control [PRE REVIEW]: OMG: A Scalable and Flexible Simulation and Testing Environment Toolbox for Intelligent Microgrid Control May 28, 2020
@danielskatz
Copy link

I fixed the whitespace issue

@danielskatz
Copy link

@whedon set v0.2.0 as version

@whedon
Copy link
Author

whedon commented May 28, 2020

OK. v0.2.0 is the version.

@danielskatz
Copy link

I don't know that the version matters at this point - we will set it at the end of the view process in case further changes are needed

@danielskatz
Copy link

@whedon check references

@whedon
Copy link
Author

whedon commented May 28, 2020

Reference check summary:

OK DOIs

- None

MISSING DOIs

- https://doi.org/10.5334/jors.188 may be missing for title: PyPSA: Python for Power System Analysis
- https://doi.org/10.1109/tpwrs.2018.2829021 may be missing for title: Pandapower: An Open-Source Python Tool for Convenient Modeling, Analysis, and Optimization of Electric Power Systems
- https://doi.org/10.1109/tie.2012.2194969 may be missing for title: Advanced Control Architectures for Intelligent Microgrids, Part I: Decentralized and Hierarchical Control
- https://doi.org/10.1109/tie.2012.2196889 may be missing for title: Advanced Control Architectures for Intelligent Microgrids, Part II: Power Quality, Energy Storage, and AC/DC Microgrids

INVALID DOIs

- None

@danielskatz
Copy link

👋 @stheid - Thanks for your submission to JOSS. As described in our blog post announcing the reopening of JOSS, we're currently working in a "reduced service mode", limiting the number of papers assigned to any individual editor.

Since reopening JOSS last week, we've had > 60 papers submitted and as such, now that yours is complete, it has been put in our backlog that we will be working through over the coming weeks and months.

Thanks in advance for your patience!

(Also, I see some possibly missing DOIs in the references - feel free to make change to the bib or md files, and enter @whedon generate pdf as a new comment here to check the results)

@danielskatz danielskatz added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label May 28, 2020
@labarba
Copy link
Member

labarba commented Jun 11, 2020

👋 @sjpfenninger — Could you have a look at this submission and let us know if you can handle it as editor?
Title: OMG: A Scalable and Flexible Simulation and Testing Environment Toolbox for Intelligent Microgrid Control
Article proof

@labarba
Copy link
Member

labarba commented Jun 11, 2020

@whedon invite @sjpfenninger as editor

@whedon
Copy link
Author

whedon commented Jun 11, 2020

@sjpfenninger has been invited to edit this submission.

@Kevin-Mattheus-Moerman
Copy link
Member

@sjpfenninger can you handle this submission?

@Kevin-Mattheus-Moerman
Copy link
Member

@sjpfenninger @KristinaRiemer @usethedata could one of you edit this submission? Thanks

1 similar comment
@Kevin-Mattheus-Moerman
Copy link
Member

@sjpfenninger @KristinaRiemer @usethedata could one of you edit this submission? Thanks

@whedon
Copy link
Author

whedon commented Jun 19, 2020

Here are some things you can ask me to do:

# List all of Whedon's capabilities
@whedon commands

# Assign a GitHub user as the sole reviewer of this submission
@whedon assign @username as reviewer

# Add a GitHub user to the reviewers of this submission
@whedon add @username as reviewer

# Re-invite a reviewer (if they can't update checklists)
@whedon re-invite @username as reviewer

# Remove a GitHub user from the reviewers of this submission
@whedon remove @username as reviewer

# List of editor GitHub usernames
@whedon list editors

# List of reviewers together with programming language preferences and domain expertise
@whedon list reviewers

# Change editorial assignment
@whedon assign @username as editor

# Set the software archive DOI at the top of the issue e.g.
@whedon set 10.0000/zenodo.00000 as archive

# Set the software version at the top of the issue e.g.
@whedon set v1.0.1 as version

# Open the review issue
@whedon start review

EDITORIAL TASKS

# Compile the paper
@whedon generate pdf

# Compile the paper from alternative branch
@whedon generate pdf from branch custom-branch-name

# Remind an author or reviewer to return to a review after a
# certain period of time (supported units days and weeks)
@whedon remind @reviewer in 2 weeks

# Ask Whedon to do a  dry run of accepting the paper and depositing with Crossref
@whedon accept

# Ask Whedon to check the references for missing DOIs
@whedon check references

# Ask Whedon to check repository statistics for the submitted software
@whedon check repository

EiC TASKS

# Invite an editor to edit a submission (sending them an email)
@whedon invite @editor as editor

# Reject a paper
@whedon reject

# Withdraw a paper
@whedon withdraw

# Ask Whedon to actually accept the paper and deposit with Crossref
@whedon accept deposit=true

@stheid
Copy link

stheid commented Jun 19, 2020

Hey @stheid - did you have any recommendations for reviewers (list here)? If not, I will assign a couple. Thanks!

ahm, i have no specific preference. i guess someone with the background to electrical engeneering; control; or reinforcement learning would be good

@dhhagan
Copy link

dhhagan commented Jun 23, 2020

@garrettj403 and @katyhuff do you have the bandwidth to review this manuscript?

@garrettj403
Copy link

Hi @dhhagan, unfortunately I don't have any time right now. Looks like an interesting project!

@katyhuff
Copy link
Member

I can review it this weekend, but not sooner (and maybe not later). If that works, @dhhagan , please count me in.

@dhhagan
Copy link

dhhagan commented Jun 23, 2020

@katyhuff thank you! Sounds great. @whedon assign @katyhuff as reviewer

@danielskatz
Copy link

@dhhagan - whedon commands need to be the first thing in a comment

@dhhagan
Copy link

dhhagan commented Jun 23, 2020

@danielskatz Thanks for the info!

@dhhagan
Copy link

dhhagan commented Jun 23, 2020

@whedon assign @katyhuff as reviewer

@whedon whedon assigned dhhagan and katyhuff and unassigned dhhagan Jun 23, 2020
@whedon
Copy link
Author

whedon commented Jun 23, 2020

OK, @katyhuff is now a reviewer

@dhhagan
Copy link

dhhagan commented Jun 23, 2020

@kczimm @IgorBaratta @pdebuyl are one of you available and interested in completing this review?

@pdebuyl
Copy link

pdebuyl commented Jun 25, 2020

@dhhagan I prefer to skip this one as I am not familiar with the topic.

@kczimm
Copy link

kczimm commented Jun 25, 2020

@dhhagan sorry, I’m unavailable at this time.

@dhhagan
Copy link

dhhagan commented Jun 30, 2020

@garrettj403 - Do you have the availability to review this manuscript?

@garrettj403
Copy link

Hi @dhhagan, unfortunately I don't have any time right now. Looks like an interesting project!

@dhhagan
Copy link

dhhagan commented Jul 3, 2020

@jsgalan @gonsie @CameronDevice - are one you able to review this manuscript?

@gonsie
Copy link

gonsie commented Jul 3, 2020

This is a bit outside my area, but I can do it if none of the others are available.

@dhhagan
Copy link

dhhagan commented Jul 4, 2020

@whedon add @gonsie as reviewer. Thanks @gonsie

@whedon whedon assigned dhhagan, gonsie and katyhuff and unassigned katyhuff and dhhagan Jul 4, 2020
@whedon
Copy link
Author

whedon commented Jul 4, 2020

OK, @gonsie is now a reviewer

@dhhagan
Copy link

dhhagan commented Jul 4, 2020

@whedon start review

@whedon
Copy link
Author

whedon commented Jul 4, 2020

OK, I've started the review over in #2435.

@whedon whedon closed this as completed Jul 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests