Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: Noisyopt #258

Closed
17 tasks done
whedon opened this issue May 10, 2017 · 6 comments
Closed
17 tasks done

[REVIEW]: Noisyopt #258

whedon opened this issue May 10, 2017 · 6 comments
Labels
accepted published Papers published in JOSS recommend-accept Papers recommended for acceptance in JOSS. review

Comments

@whedon
Copy link

whedon commented May 10, 2017

Submitting author: @andim (Andreas Mayer)
Repository: https://github.com/andim/noisyopt
Version: v0.2
Editor: @arokem
Reviewer: @nirum
Archive: 10.5281/zenodo.580120

Status

status

Status badge code:

HTML: <a href="http://joss.theoj.org/papers/4d17c8d6e2cfe6505ca5ccdace5e123b"><img src="http://joss.theoj.org/papers/4d17c8d6e2cfe6505ca5ccdace5e123b/status.svg"></a>
Markdown: [![status](http://joss.theoj.org/papers/4d17c8d6e2cfe6505ca5ccdace5e123b/status.svg)](http://joss.theoj.org/papers/4d17c8d6e2cfe6505ca5ccdace5e123b)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer questions

Conflict of interest

  • As the reviewer I confirm that there are no conflicts of interest for me to review this work (such as being a major contributor to the software).

General checks

  • Repository: Is the source code for this software available at the repository url?
  • License: Does the repository contain a plain-text LICENSE file with the contents of an OSI approved software license?
  • Version: Does the release version given match the GitHub release (v0.2)?
  • Authorship: Has the submitting author (@andim) made major contributions to the software?

Functionality

  • Installation: Does installation proceed as outlined in the documentation?
  • Functionality: Have the functional claims of the software been confirmed?
  • Performance: Have any performance claims of the software been confirmed?

Documentation

  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • Installation instructions: Is there a clearly-stated list of dependencies? Ideally these should be handled with an automated package management solution.
  • Example usage: Do the authors include examples of how to use the software (ideally to solve real-world analysis problems).
  • Functionality documentation: Is the core functionality of the software documented to a satisfactory level (e.g. API method documentation)?
  • Automated tests: Are there automated tests or manual steps described so that the function of the software can be verified?
  • Community guidelines: Are there clear guidelines for third parties wishing to 1) Contribute to the software 2) Report issues or problems with the software 3) Seek support

Software paper

  • Authors: Does the paper.md file include a list of authors with their affiliations?
  • A statement of need: Do the authors clearly state what problems the software is designed to solve and who the target audience is?
  • References: Do all archival references that should have a DOI list one (e.g. papers, datasets, software)?
@nirum
Copy link

nirum commented May 23, 2017

The author(s) have addressed all of my comments and closed the issues, which are linked below.

andim/noisyopt#4
andim/noisyopt#5
andim/noisyopt#6
andim/noisyopt#7
andim/noisyopt#8
andim/noisyopt#9
andim/noisyopt#10
andim/noisyopt#11

@nirum
Copy link

nirum commented May 23, 2017

@arfon @arokem what's the next step here? It looks like @andim has already created a DOI for the package:

DOI

@andim
Copy link

andim commented May 30, 2017

Just wanted to ping you again @arfon @arokem ! Let me know if any action is needed from my side at this point.

@arfon
Copy link
Member

arfon commented May 31, 2017

@whedon set 10.5281/zenodo.580120 as archive

@whedon
Copy link
Author

whedon commented May 31, 2017

OK. 10.5281/zenodo.580120 is the archive.

@arfon
Copy link
Member

arfon commented May 31, 2017

@nirum - many thanks for your review here and to @arokem for editing this one ✨

@andim - your paper is now accepted into JOSS and your DOI is http://dx.doi.org/10.21105/joss.00258 ⚡️:rocket: :boom:

@arfon arfon closed this as completed May 31, 2017
@nirum nirum added the accepted label May 31, 2017
@whedon whedon added published Papers published in JOSS recommend-accept Papers recommended for acceptance in JOSS. labels Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted published Papers published in JOSS recommend-accept Papers recommended for acceptance in JOSS. review
Projects
None yet
Development

No branches or pull requests

4 participants