New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: textnets: A Python package for text analysis with networks #2594
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @sara-02, @tresoldi it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
PDF failed to compile for issue #2594 with the following error: Can't find any papers to compile :-( |
@whedon generate pdf from branch joss |
|
@jboynyc great library, thank you! I can see myself using it for at least one project I have in mind. Nothing to mention in terms of the code and package structure, quality is very good both in terms of coding and documenting. I've just filed an issue on the only real problem I saw. Some additional points/comments here:
On the manuscript:
|
Thanks, @tresoldi! I will push a new version of the paper by the end of the week adding a more detailed statement of need to the background section and doing my best to fix figure placement. I'll let you know when I'm ready. I also really like your idea of creating a Conda package. I've started looking into it. |
@whedon generate pdf from branch joss |
|
All my points were addressed, only issue jboynyc/textnets#14 still pending. |
Release 0.4.10 closes jboynyc/textnets#14. Many thanks @tresoldi for the helpful and encouraging review! |
Great, @jboynyc , and thanks once more for this package. @gkthiruvathukal No further requests from me, approved. |
I'd love to hear about any projects you use it for, so please do ping me! |
I made a minor update to the paper noting the ability to install from conda-forge. |
@whedon generate pdf from branch joss |
|
@gkthiruvathukal We can move towards acceptance, for me. All boxes checked. 😃 |
@jboynyc I have a query regarding this point
I could not find a command for the same, have added an issue here: https://github.com/jboynyc/textnets Apart from this point, the rest of the checklist is complete from my side as well. |
|
@gkthiruvathukal - when the paper is in a branch, you need to accept it from the branch: |
@whedon accept from branch joss |
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#1812 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1812, then you can now move forward with accepting the submission by compiling again with the flag
|
|
👋 @sara-02 - above you say that the unchecked item in your list is satisfied, so I am going to move the acceptance forward, but if you could check off the item itself, it will be slightly cleaner. |
👋 @jboynyc - Some fixes are needed in the paper: jboynyc/textnets#19 and jboynyc/textnets#20 |
Done |
Merged! Thanks for catching those. |
@whedon accept from branch joss |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#1815 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1815, then you can now move forward with accepting the submission by compiling again with the flag
|
@whedon accept deposit=true from branch joss |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to @jboynyc (John Boy)!! And thanks to @sara-02 & @tresoldi for reviewing, and @gkthiruvathukal for editing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thanks to all involved! |
Submitting author: @jboynyc (John Boy)
Repository: https://github.com/jboynyc/textnets
Version: v0.4.10
Editor: @gkthiruvathukal
Reviewer: @sara-02, @tresoldi
Archive: 10.5281/zenodo.4028610
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@sara-02 & @tresoldi, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @gkthiruvathukal know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @sara-02
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @tresoldi
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: