-
-
Notifications
You must be signed in to change notification settings - Fork 37
-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: BioPandas: Working with molecular structures in pandas DataFrames #279
Comments
Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS. @krother it looks like you're currently assigned as the reviewer for this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As as reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all JOSS reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
|
The PDB parsing works out of the box and does not require further explanation. It is a killer app in itself. I found a (probably small) issue in the RMSD calculation feature. |
DOI references for the PDB could be: |
For pandas, a book written by Wes exists (http://shop.oreilly.com/product/0636920023784.do), but it has no DOI. I'd leave the pandas and MOL reference as they are. |
Thanks for the feedback!
I saw a note about that issue in the biopandas repo and will take a look at it tonight and hopefully resolve it.
When I wrote this I had another paper in mind that I was working on recently. I am just waiting for the co-author feedback and then the manuscript is going to be submitted to JCIM ~ next week. But I guess it will probably take a bit longer until that's published and citable. There, I used biopandas as an engine to perform filtering by functional groups (spatial distance between functional groups, charge range, and hybridization). I only have a brief section on that in the docs here: In this example, you can think of the |
Thanks, updated those references! |
argh, I didn't spot the menu bar on top on the documentation page. It's quite impressive and complete as it is, thanks! 👍 |
This should be fixed in the master branch now (BioPandas/biopandas#34). For JOSS, I assume I need to make a new version release so that this change takes effect? It's not a problem, I think I should hold off a bit though, in case there's something else that needs to be addressed. (Once everything looks fine, I can make a new stable release, i.e., 2.1.0 -> 2.1.1 or 2.2.0). Is that okay? |
Checked the changed version by installing with pip directly from github. Great you put this in the documentation! And it works, too. |
Created a PR where I indicated a possible location for the DOI in the PDB reference. No more issues from me. Congratulations to this contribution, it is time to get the word out! |
Thanks @krother . Just merged the DOI PR, and I am happy to hear that everything looks fine now :) |
OK, review done. |
@rasbt - Could you move the references you currently have in the When you've done that could you make an archive of the reviewed software in Zenodo/figshare/other service and update this thread with the DOI of the archive? I can then move forward with accepting the submission. |
@arfon no problem. I moved the references to a separate bibtex file, paper.bib.
Here's the link for the 0.2.1 version that was reviewed: https://zenodo.org/record/574879 This existed prior to the submission though and thus, it doesn't include the paper.md and paper.bib files. I made a new biopandas version (v0.2.1 -> v0.2.2) for zenodo incorporating the paper files and also including a small fix that came up during the review process. The zenodo link and doi: |
@whedon set 10.5281/zenodo.804030 as archive |
OK. 10.5281/zenodo.804030 is the archive. |
@krother many thanks for your rapid review here and to @pjotrp for editing this submission ✨ @rasbt - your paper is now accepted into JOSS and your DOI is http://dx.doi.org/10.21105/joss.00279 ⚡️:rocket: :boom: |
That's awesome! Thanks a lot, everyone, for all the work and the very seamless process! |
Submitting author: @rasbt (Sebastian Raschka)
Repository: https://github.com/rasbt/biopandas
Version: v0.2.2
Editor: @pjotrp
Reviewer: @krother
Archive: 10.5281/zenodo.804030
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer questions
Conflict of interest
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: