-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: secuTrialR: Seamless interaction with clinical trial databases in R #2816
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @pacoramon, @sachsmc it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
@pacoramon, @sachsmc - thanks for agreeing to review this submissions. This is where the review happens. You can find some instructions above, as well as your individual checklists. Don't hesitate to ping me if you have any questions (I will also be checking in regularly). |
Thank you for taking this on from my side too 👍 |
Hi @PatrickRWright , I noted a few small issues with the documentation and the software paper in issues 225 and 226 on your repo: SwissClinicalTrialOrganisation/secuTrialR#225 Otherwise the package looks and works great! Best wishes, Michael |
Thank you @sachsmc for the taking the time and your comments. I'll try and get on to them asap. |
Note to myself: Add the reviewers and editor to the acknowledgements. |
👋 @sachsmc, please update us on how your review is going. |
👋 @pacoramon, please update us on how your review is going. |
@whedon generate pdf |
@pacoramon can you tell us your legal name so we can adjust it in the acknowledgements? |
Good question. I'm not sure why that link is not wrapped like the others. Perhaps someone from the @openjournals/dev team has an idea. |
@csoneson One way to solve it requires modifying the latex template (not sure how onerous that would be). If you add the code
to the header before the hyperref package is loaded, it will break the url at hyphens. By default, it will only break at slashes. https://tex.stackexchange.com/questions/175399/line-breaking-of-urls-at |
|
@whedon generate pdf |
@whedon generate pdf |
A quick fix would be to use the shorter-form url for the same article: |
@whedon set 1.0.6 as version |
OK. 1.0.6 is the version. |
@whedon accept |
|
Thanks @PatrickRWright - the associate editor in chief on rotation will take over from here. |
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#1928 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1928, then you can now move forward with accepting the submission by compiling again with the flag
|
|
Should I run this Also I saw that the XML omits the middle names. i.e. |
I'll take over from here, with a final proofreading and then the acceptance. I'll also look at the name issue in the XML - thanks for catching it as a potential issue. |
Please merge the changes in SwissClinicalTrialOrganisation/secuTrialR#229 or let me know what you don't agree with. |
It is merged. |
@whedon accept |
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#1929 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#1929, then you can now move forward with accepting the submission by compiling again with the flag
|
|
@PatrickRWright - It turns out that Crossref only wants the given name (e.g. Alan). We omit the middle initial deliberately. But since we add the ORCID, the authors should still be uniquely identified. |
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to @PatrickRWright (Patrick R. Wright) and co-authors!! And thanks to @pacoramon & @sachsmc for reviewing and @csoneson for editing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @PatrickRWright (Patrick R. Wright)
Repository: https://github.com/SwissClinicalTrialOrganisation/secuTrialR
Version: 1.0.6
Editor: @csoneson
Reviewer: @pacoramon, @sachsmc
Archive: 10.5281/zenodo.4280767
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@pacoramon & @sachsmc, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @csoneson know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @pacoramon
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @sachsmc
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: