New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: EMD: Empirical Mode Decomposition and Hilbert-Huang Spectral Analyses in Python #2977
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @JanCBrammer, @EtienneCmb, @neurofractal it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
PDF failed to compile for issue #2977 with the following error: /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-92346a0773a4/lib/whedon/author.rb:72:in |
|
Hello - thanks all for your time! I have the latest version of the paper in a branch for the moment, I think this is causing the whedon error above... |
@whedon generate pdf from branch 33-joss-revisions |
|
Hi @AJQuinn, Some minor comments about the draft :
Small question : is the holospectrum related to phase-amplitude coupling and comodulogram plot? |
You could also add one sentence to the manuscript to highlight that some computations can be accelerated though multi-processing. This is a nice feature that doesn't seems to be present over all other EMD packages |
@whedon re-invite @JanCBrammer as reviewer |
I'm sorry @JanCBrammer, I'm afraid I can't do that. That's something only editors are allowed to do. |
@dpsanders, could you re-invite me (invitation has expired)? |
@whedon re-invite @JanCBrammer as reviewer |
OK, the reviewer has been re-invited. @JanCBrammer please accept the invite by clicking this link: https://github.com/openjournals/joss-reviews/invitations |
Hi all, I've made some paper changes based on @EtienneCmb suggestions above. Please let me know if these are ok and if there are any more! We followed up the point about phase-amplitude coupling elsewhere in the end but just in case others are interested... the Holospectrum quantifies any amplitude modulations present in an oscillatory signal but does not formally relate these to the phase of a low frequency signal. The methods measure complementary things but you would still need a phase x frequency plot or comodulogram alongside the holospectrum for a complete PAC measure (there is an example of this at the end of the Holospectrum tutorial) Cheers, |
@whedon generate pdf from branch 33-joss-revisions |
|
👋 @EtienneCmb, please update us on how your review is going. |
👋 @JanCBrammer, please update us on how your review is going. |
OK. 0.4.0 is the version. |
@AJQuinn: Great, thanks! Could you please make sure that the author info on Zenodo exactly corresponds to the authors of the paper? Thanks! |
@whedon set https://doi.org/10.5281/zenodo.4647949 as archive |
OK. 10.5281/zenodo.4647949 is the archive. |
@whedon accept |
|
|
PDF failed to compile for issue #2977 with the following error: |
Ah, apologies. I've updated this with the correct info: https://zenodo.org/record/4647949 I'm not sure what the compile issue above is related to? please let me know if I can do anything to sort it. Cheers, |
@whedon generate pdf from branch 33-joss-revisions |
|
@whedon accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#2169 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#2169, then you can now move forward with accepting the submission by compiling again with the flag
|
everything looks good!! |
@whedon accept deposit=true |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congrats on your new publication @AJQuinn! Thanks to editor @dpsanders and reviewers @JanCBrammer, @EtienneCmb, and @neurofractal for your time, hard work, and expertise!! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Congratulations @AJQuinn! Many thanks to @JanCBrammer, @EtienneCmb and @neurofractal for your detailed and helpful reviews, and to @kthyng for help with the process. |
Submitting author: @AJQuinn (Andrew Quinn)
Repository: https://gitlab.com/emd-dev/emd
Version: 0.4.0
Editor: @dpsanders
Reviewer: @JanCBrammer, @EtienneCmb, @neurofractal
Archive: 10.5281/zenodo.4647949
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@JanCBrammer & @EtienneCmb & @neurofractal, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @dpsanders know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @JanCBrammer
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @EtienneCmb
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @neurofractal
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: