Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: arrgh: a Go interface to the OpenCPU R server system #312

Closed
whedon opened this issue Jul 9, 2017 · 25 comments
Closed

[PRE REVIEW]: arrgh: a Go interface to the OpenCPU R server system #312

whedon opened this issue Jul 9, 2017 · 25 comments
Assignees

Comments

@whedon
Copy link

whedon commented Jul 9, 2017

Submitting author: @kortschak (Robert Daniel Kortschak)
Repository: https://github.com/kortschak/arrgh
Version: v1.0.0
Editor: @pjotrp
Reviewer: @brentp

Author instructions

Thanks for submitting your paper to JOSS @kortschak. The JOSS editor (shown at the top of this issue) will work with you on this issue to find a reviewer for your submission before creating the main review issue.

kortschak if you have any suggestions for potential reviewers then please mention them here in this thread. In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission.

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Jul 9, 2017

Hello human, I'm @whedon. I'm here to help you with some common editorial tasks for JOSS.

For a list of things I can do to help you, just type:

@whedon commands

@arfon
Copy link
Member

arfon commented Jul 21, 2017

👋 @acabunoc - would you be willing to edit this submission for JOSS?

@arfon
Copy link
Member

arfon commented Aug 12, 2017

👋 thanks for your submission to JOSS. From a quick inspection of this submission it's not entirely obvious that it meets our submission criteria. In particular, this item:

  • Your software should have an obvious research application

Could you confirm here that there is a research application for this software (and explain what that application is)? The section 'what should my paper contain' has some guidance for the sort of content we're looking to be present in the paper.md.

Many thanks!

@kortschak
Copy link

I am confused, the paper clearly states that the package is intended to be used for interfacing with R, which is primarily a research software. The paper also explains why this would be useful, in that Go is a good language for performing scientific analyses for many reasons, but that R provides a much richer statistical analysis support base and so use the two together is a benefit:

Go is a simple statically typed compiled language that provides many benefits for scientific computing. However, Go currently lacks the rich statistical analysis tools available in R. So an interface between R and Go would allow building analytical tools utilising the simplicity and high performance of Go and the statistical analysis tools available within R.

@kortschak
Copy link

To give an explicit use case (hypothetical), if a person wanted to perform a genomics analysis using Go and the bíogo ncbi package (interestingly built around the same server/client model as the arrgh package) requiring some statistical analysis, it may be necessary to use R. The arrgh package would facilitate this analysis. The need for statistical analysis to support research seemed so obvious to me that I did not include any text to justify it; should I?

@pjotrp
Copy link

pjotrp commented Aug 14, 2017

@kortschak it will be good to give an example of use in research context. @arfon I can be the editor.

@kortschak
Copy link

I am teaching at the moment and this will take some time to put together, but it does honestly strike me as very odd. These are two languages that are used for scientific research, with different strengths that can, if interfaced, strengthen each other.

@arfon
Copy link
Member

arfon commented Aug 15, 2017

I am teaching at the moment and this will take some time to put together, but it does honestly strike me as very odd. These are two languages that are used for scientific research, with different strengths that can, if interfaced, strengthen each other.

Hi @kortschak. We've been discussing this submission as an editorial board and the primary concern we have is that this submission falls into the 'utility package' category (http://joss.theoj.org/about#submission_requirements). We definitely understand the potential value of connecting these two languages, we're simply looking for an illustration of this for the reader. Better yet, if you have used this in some of your own ongoing research then cite that too.

@pjotrp
Copy link

pjotrp commented Aug 15, 2017

@kortschak
Copy link

kortschak commented Aug 16, 2017

@pjotrp I'm not sure what I should take from that. The two approaches are very different, reflecting the differences in the underpinning philosophies of python and Go, and also reflects the differences in approaches to performance optimisation seen in the two languages; the package use example of edger in figure 3 would be an anti-pattern in Go because of the heavy inter-process communication purely for the purpose of retaining the data in the python space. It is also difficult for me to distinguish the packages there from what @arfon describes here as a 'utility package'. The RPy2 packages do things that in my work would be done purely in R, and serve only to wrap that in a different syntax.

I will write up an example of a graph structure analysis where the graph statistics are generated in Go using packages in the gonum graph suite and the statistical analysis and plotting is done using arrgh to interface to R. If this plan is satisfactory, then I can move ahead, otherwise I am at a loss with how to move this forward, and would continue to be confused given other papers that have been moved onto review/published here recently that IMO sit squarely in the same space.

@arfon
Copy link
Member

arfon commented Aug 16, 2017

I will write up an example of a graph structure analysis where the graph statistics are generated in Go using packages in the gonum graph suite and the statistical analysis and plotting is done using arrgh to interface to R. If this plan is satisfactory, then I can move ahead, otherwise I am at a loss with how to move this forward, and would continue to be confused given other papers that have been moved onto review/published here recently that IMO sit squarely in the same space.

Thanks @kortschak. I realize there many be some apparent inconsistencies in editorial policy - this is because we've recently updated our submission guidelines (see openjournals/joss#307).

@kortschak
Copy link

The inconsistencies are temporal as well. I see things in the survey I did this morning that were moved to review or accepted after that PR was merged. This is wildly frustrating, moreso given that this paper was submitted more than a month ago, well before that PR was sent.

@pjotrp
Copy link

pjotrp commented Aug 16, 2017

Hey Dan. We are all volunteers. Please appreciate that. All good intentions. I am with you that we should push forward. The idea of a GO graph is very good.

@pjotrp
Copy link

pjotrp commented Sep 5, 2017

@whedon assign @pjotrp as editor

@whedon
Copy link
Author

whedon commented Sep 5, 2017

OK, the editor is @pjotrp

@pjotrp
Copy link

pjotrp commented Sep 5, 2017

@kortschak ping me when you are ready and I'll look for a reviewer. Since you have published with JOSS before I trust you to be ready at some point.

@kortschak
Copy link

Thanks for the patience @pjotrp, I will let you know when I have the worked up examples as a PR.

@kortschak
Copy link

@pjotrp
Copy link

pjotrp commented Dec 16, 2017

Thanks. I'll start asking around for a reviewer.

@pjotrp
Copy link

pjotrp commented Dec 19, 2017

@brentp would you mind reviewing this submission? Or suggest someone who would be interested in using R from Go?

@brentp
Copy link

brentp commented Dec 19, 2017

yes, I can review.

@pjotrp
Copy link

pjotrp commented Dec 19, 2017

@whedon assign @brentp as reviewer

@whedon
Copy link
Author

whedon commented Dec 19, 2017

OK, the reviewer is @brentp

@whedon whedon assigned brentp and pjotrp and unassigned pjotrp Dec 19, 2017
@pjotrp
Copy link

pjotrp commented Dec 19, 2017

@whedon start review magic-word=bananas

@whedon
Copy link
Author

whedon commented Dec 19, 2017

OK, I've started the review over in #517. Feel free to close this issue now!

@pjotrp pjotrp closed this as completed Dec 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants