-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: Easy3D: a lightweight, easy-to-use, and efficient C++ library for processing and rendering 3D data #3255
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @adi3, @vissarion, @ @bhajay it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
PDF failed to compile for issue #3255 with the following error:
|
OK, the reviewer has been re-invited. @bhajay please accept the invite by clicking this link: https://github.com/openjournals/joss-reviews/invitations |
|
@whedon generate pdf from branch joss |
|
PDF failed to compile for issue #3255 with the following error:
|
@openjournals/dev can you see what's wrong here? |
@whedon generate pdf from branch joss |
|
👋 @vissarion, please update us on how your review is going (this is an automated reminder). |
👋 @adi3, please update us on how your review is going (this is an automated reminder). |
@LiangliangNan Your |
@adi3 Thanks for the comments. The paper has been restructured and an additional figure has also been added to demonstrate the four different data structures supported by the software. |
|
|
|
@Kevin-Mattheus-Moerman The title has been updated. Thanks! |
@whedon recommend-accept |
|
PDF failed to compile for issue #3255 with the following error:
|
@whedon recommend-accept from branch joss |
I'm sorry human, I don't understand that. You can see what commands I support by typing:
|
@whedon recommend-accept from branch joss |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#2520 If the paper PDF and Crossref deposit XML look good in openjournals/joss-papers#2520, then you can now move forward with accepting the submission by compiling again with the flag
|
👋 @Kevin-Mattheus-Moerman - I'm not sure what went wrong when you tried this yesterday, but it's now working. Please feel free to handle the final processing yourself as a AEiC, or let me know if you want me to do it as the on-duty AEiC. |
👋 @LiangliangNan - please fix the incorrect DOI (remove the 'https://doi.org/' prefix) as |
@whedon generate pdf from branch joss |
|
@danielskatz The DOI has been fixed. Please proceed. Thanks! |
@whedon check references from branch joss |
|
|
@whedon accept deposit=true from branch joss |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Yes. Everything looks good. |
Congratulatios @LiangliangNan And thank you so much to @adi3, @vissarion, and @bhajay for your review efforts! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @LiangliangNan (Liangliang Nan)
Repository: https://github.com/LiangliangNan/Easy3D
Version: v2.4.5
Editor: @Kevin-Mattheus-Moerman
Reviewer: @adi3, @vissarion, @bhajay
Archive: 10.5281/zenodo.4967311
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@adi3 & @vissarion & @ @bhajay, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @Kevin-Mattheus-Moerman know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @adi3
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @vissarion
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @bhajay
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: