[PRE REVIEW]: Reel1.0 - A visualization tool for evaluating powder diffraction refinements #3443

whedon · 2021-07-01T20:01:44Z

Submitting author: @fgjorup (Frederik Holm Gjørup)
Repository: https://github.com/fgjorup/Reel/
Version: v.1.1.1
Editor: @rkurchin
Reviewers: @cmbiwer, mikapfl
Managing EiC: Arfon Smith

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/95de1942ca8f4bbf3c4fad168d641054"><img src="https://joss.theoj.org/papers/95de1942ca8f4bbf3c4fad168d641054/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/95de1942ca8f4bbf3c4fad168d641054/status.svg)](https://joss.theoj.org/papers/95de1942ca8f4bbf3c4fad168d641054)

Author instructions

Thanks for submitting your paper to JOSS @fgjorup. Currently, there isn't an JOSS editor assigned to your paper.

@fgjorup if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands

The text was updated successfully, but these errors were encountered:

whedon · 2021-07-01T20:01:47Z

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

whedon · 2021-07-01T20:01:54Z

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.09 s (148.7 files/s, 79194.3 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                           9            275            220           5642
Qt                               1              0              0            732
Markdown                         1             10              0             27
DOS Batch                        2              0              0             19
-------------------------------------------------------------------------------
SUM:                            13            285            220           6420
-------------------------------------------------------------------------------


Statistical information for the repository '33153b005484da6d0915ff11' was
gathered on 2021/07/01.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
Frederik                         1             0           6702           14.27
Frederik Holm Gjørup            17         11786          13655           54.18
fgjorup                          6         14761             53           31.55

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
Frederik Holm Gjørup       6137           52.1          1.5                2.70

whedon · 2021-07-01T20:01:54Z

PDF failed to compile for issue #3443 with the following error:

 Can't find any papers to compile :-(

arfon · 2021-07-01T20:04:44Z

@whedon generate pdf from branch JOSS-submission

whedon · 2021-07-01T20:04:47Z

Attempting PDF compilation from custom branch JOSS-submission. Reticulating splines etc...

whedon · 2021-07-01T20:04:55Z

PDF failed to compile for issue #3443 with the following error:

 ORCID looks malformed
/app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon.rb:155:in `block in check_orcids': Problem with ORCID (0000-0003-3902-0247, 0000-0002-8022-5538, 0000-0001-6805-1232) for Frederik H. Gjørup , Mathias Mørch, & Mogens Christensen (RuntimeError)
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon.rb:153:in `each'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon.rb:153:in `check_orcids'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon.rb:90:in `initialize'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon/processor.rb:38:in `new'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/lib/whedon/processor.rb:38:in `set_paper'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/bin/whedon:58:in `prepare'
	from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/command.rb:27:in `run'
	from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/invocation.rb:126:in `invoke_command'
	from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor.rb:387:in `dispatch'
	from /app/vendor/bundle/ruby/2.6.0/gems/thor-0.20.3/lib/thor/base.rb:466:in `start'
	from /app/vendor/bundle/ruby/2.6.0/bundler/gems/whedon-b63fc70cc085/bin/whedon:131:in `<top (required)>'
	from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in `load'
	from /app/vendor/bundle/ruby/2.6.0/bin/whedon:23:in `<main>'

arfon · 2021-07-01T20:05:43Z

@fgjorup - thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

fgjorup · 2021-07-02T07:40:09Z

My suggestions for potential reviewers from the provided list, based on the topics materials science, diffraction, neutrons, x-ray, and python:
benjaminbolling
cmbiwer
pgg1610
jwuttke
mikapfl
KedoKudo
cmbiwer
stuartcampbell
marcocamma
taw10
yxqd

kthyng · 2021-07-15T18:26:23Z

Hi @rkurchin! I found another that may fit with your expertise. What do you think?

kthyng · 2021-07-15T18:26:29Z

@whedon invite @rkurchin as editor

whedon · 2021-07-15T18:26:32Z

@rkurchin has been invited to edit this submission.

rkurchin · 2021-07-16T15:07:20Z

@whedon assign @rkurchin as editor

whedon · 2021-07-16T15:07:24Z

OK, the editor is @rkurchin

rkurchin · 2021-07-16T21:37:20Z

@cmbiwer, @mikapfl, would you be willing to review this submission for JOSS?

We carry out our checklist-driven reviews here in GitHub issues according to these guidelines. You can find out more about this submission in the first comment in this issue. Note that our editorial robot whedon is having trouble compiling the PDF right now, but if you hop over to the submission branch of their repo you can see the manuscript as well.

rkurchin · 2021-07-16T21:37:24Z

@fgjorup, could you please correct the ORCID issue referenced above? Currently, your author/ORCID list is formatted thusly:

  - name: Frederik H. Gjørup , Mathias Mørch, & Mogens Christensen
    orcid: 0000-0003-3902-0247, 0000-0002-8022-5538, 0000-0001-6805-1232
    affiliation: "1"

I believe replacing it with the following should fix it:

  - name: Frederik H. Gjørup
    orcid: 0000-0003-3902-0247
    affiliation: "1"

  - name: Mathias Mørch
    orcid: 0000-0002-8022-5538
    affiliation: "1"

  - name: Mogens Christensen
    orcid: 0000-0001-6805-1232
    affiliation: "1"

mikapfl · 2021-07-19T08:43:40Z

Hi,

I haven't done any Rietveld refinement myself, so I can't really review the scientific usefulness of the software and how it relates to the wider ecosystem of powder diffraction analysis software. If that is fine with you, I would be happy to do a review. (-:

Cheers,

Mika

cmbiwer · 2021-07-19T15:03:16Z

Hi, I have worked on several visualization tools/automation tools for diffraction analysis and Rietveld analysis, and I am available to review this submission.

rkurchin · 2021-07-19T18:35:53Z

@whedon assign @cmbiwer as reviewer

whedon · 2021-07-19T18:35:57Z

OK, @cmbiwer is now a reviewer

rkurchin · 2021-07-19T18:38:01Z

Thanks, Christopher! And thanks for info, Mika, I'll try one or two other people and come back to you if need be. :)

rkurchin · 2021-07-19T18:39:17Z

@stuartcampbell, would you be able/willing to review this submission to JOSS?

We carry out our checklist-driven reviews here in GitHub issues according to these guidelines. You can find out more about this submission in the first comment in this issue. Note that our editorial robot whedon is having trouble compiling the PDF right now, but if you hop over to the submission branch of their repo you can see the manuscript as well.

rkurchin · 2021-07-23T22:52:07Z

@marcocamma, would you be able/willing to review this submission to JOSS?

We carry out our checklist-driven reviews here in GitHub issues according to these guidelines. You can find out more about this submission in the first comment in this issue. Note that our editorial robot whedon is having trouble compiling the PDF right now, but if you hop over to the submission branch of their repo you can see the manuscript as well.

rkurchin · 2021-07-28T16:42:13Z

@mikapfl, you still game to take this one? It seems Christopher can cover the Rietveld-specific stuff, and I think your broader perspective could be helpful. I'll wait for a confirmation from you that it's still okay.

rkurchin · 2021-07-28T16:43:56Z

@fgjorup, could you please correct the ORCID issue referenced above? Currently, your author/ORCID list is formatted thusly:

  - name: Frederik H. Gjørup , Mathias Mørch, & Mogens Christensen
    orcid: 0000-0003-3902-0247, 0000-0002-8022-5538, 0000-0001-6805-1232
    affiliation: "1"

I believe replacing it with the following should fix it:

  - name: Frederik H. Gjørup
    orcid: 0000-0003-3902-0247
    affiliation: "1"

  - name: Mathias Mørch
    orcid: 0000-0002-8022-5538
    affiliation: "1"

  - name: Mogens Christensen
    orcid: 0000-0001-6805-1232
    affiliation: "1"

@fgjorup, we should be close to having two reviewers and being ready to move this to the review stage, if you could resolve this so that we can build a proof, that would be great!

mikapfl · 2021-07-29T07:55:06Z

@rkurchin Sure, I would be happy to do a review!

fgjorup · 2021-07-29T08:45:36Z

@rkurchin I believe I have fixed the issue, though I may have missed something? I'm currently out of office, but I'll do my best to help remotely.

…

________________________________ From: Rachel Kurchin ***@***.***> Sent: Wednesday, July 28, 2021, 18:44 To: openjournals/joss-reviews Cc: Frederik Holm Gjørup; Mention Subject: Re: [openjournals/joss-reviews] [PRE REVIEW]: Reel1.0 - A visualization tool for evaluating powder diffraction refinements (#3443) @fgjorup<https://github.com/fgjorup>, could you please correct the ORCID issue referenced above? Currently, your author/ORCID list is formatted thusly: - name: Frederik H. Gjørup , Mathias Mørch, & Mogens Christensen orcid: 0000-0003-3902-0247, 0000-0002-8022-5538, 0000-0001-6805-1232 affiliation: "1" I believe replacing it with the following should fix it: - name: Frederik H. Gjørup orcid: 0000-0003-3902-0247 affiliation: "1" - name: Mathias Mørch orcid: 0000-0002-8022-5538 affiliation: "1" - name: Mogens Christensen orcid: 0000-0001-6805-1232 affiliation: "1" @fgjorup<https://github.com/fgjorup>, we should be close to having two reviewers and being ready to move this to the review stage, if you could resolve this so that we can build a proof, that would be great! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#3443 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALHUHH4TQZT6IWVPGHPIWDTT2AXVRANCNFSM47VL7LGA>.

rkurchin · 2021-07-29T14:36:31Z

@whedon add mikapfl as reviewer

whedon · 2021-07-29T14:36:35Z

OK, mikapfl is now a reviewer

rkurchin · 2021-07-29T14:36:48Z

@whedon generate pdf from branch JOSS-submission

whedon · 2021-07-29T14:36:50Z

Attempting PDF compilation from custom branch JOSS-submission. Reticulating splines etc...

whedon · 2021-07-29T14:37:11Z

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

rkurchin · 2021-07-29T14:37:41Z

@whedon start review

whedon · 2021-07-29T14:37:45Z

OK, I've started the review over in #3546.

whedon added the pre-review label Jul 1, 2021

whedon added Batchfile Python labels Jul 1, 2021

arfon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jul 1, 2021

whedon assigned rkurchin Jul 16, 2021

rkurchin removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Jul 19, 2021

whedon assigned cmbiwer and rkurchin and unassigned rkurchin Jul 19, 2021

whedon assigned cmbiwer, mikapfl and rkurchin and unassigned cmbiwer and rkurchin Jul 29, 2021

whedon closed this as completed Jul 29, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PRE REVIEW]: Reel1.0 - A visualization tool for evaluating powder diffraction refinements #3443

[PRE REVIEW]: Reel1.0 - A visualization tool for evaluating powder diffraction refinements #3443

whedon commented Jul 1, 2021 •

edited

Loading

whedon commented Jul 1, 2021

whedon commented Jul 1, 2021

whedon commented Jul 1, 2021

arfon commented Jul 1, 2021

whedon commented Jul 1, 2021

whedon commented Jul 1, 2021

arfon commented Jul 1, 2021

fgjorup commented Jul 2, 2021

kthyng commented Jul 15, 2021

kthyng commented Jul 15, 2021

whedon commented Jul 15, 2021

rkurchin commented Jul 16, 2021

whedon commented Jul 16, 2021

rkurchin commented Jul 16, 2021

rkurchin commented Jul 16, 2021

mikapfl commented Jul 19, 2021

cmbiwer commented Jul 19, 2021

rkurchin commented Jul 19, 2021

whedon commented Jul 19, 2021

rkurchin commented Jul 19, 2021

rkurchin commented Jul 19, 2021

rkurchin commented Jul 23, 2021

rkurchin commented Jul 28, 2021

rkurchin commented Jul 28, 2021

mikapfl commented Jul 29, 2021

fgjorup commented Jul 29, 2021 via email

rkurchin commented Jul 29, 2021

whedon commented Jul 29, 2021

rkurchin commented Jul 29, 2021

whedon commented Jul 29, 2021

whedon commented Jul 29, 2021

rkurchin commented Jul 29, 2021

whedon commented Jul 29, 2021

[PRE REVIEW]: Reel1.0 - A visualization tool for evaluating powder diffraction refinements #3443

[PRE REVIEW]: Reel1.0 - A visualization tool for evaluating powder diffraction refinements #3443

Comments

whedon commented Jul 1, 2021 • edited Loading

Status

whedon commented Jul 1, 2021

whedon commented Jul 1, 2021

whedon commented Jul 1, 2021

arfon commented Jul 1, 2021

whedon commented Jul 1, 2021

whedon commented Jul 1, 2021

arfon commented Jul 1, 2021

fgjorup commented Jul 2, 2021

kthyng commented Jul 15, 2021

kthyng commented Jul 15, 2021

whedon commented Jul 15, 2021

rkurchin commented Jul 16, 2021

whedon commented Jul 16, 2021

rkurchin commented Jul 16, 2021

rkurchin commented Jul 16, 2021

mikapfl commented Jul 19, 2021

cmbiwer commented Jul 19, 2021

rkurchin commented Jul 19, 2021

whedon commented Jul 19, 2021

rkurchin commented Jul 19, 2021

rkurchin commented Jul 19, 2021

rkurchin commented Jul 23, 2021

rkurchin commented Jul 28, 2021

rkurchin commented Jul 28, 2021

mikapfl commented Jul 29, 2021

fgjorup commented Jul 29, 2021 via email

rkurchin commented Jul 29, 2021

whedon commented Jul 29, 2021

rkurchin commented Jul 29, 2021

whedon commented Jul 29, 2021

whedon commented Jul 29, 2021

rkurchin commented Jul 29, 2021

whedon commented Jul 29, 2021

whedon commented Jul 1, 2021 •

edited

Loading