Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PRE REVIEW]: cppTPSA/pyTPSA: a C++/Python package for truncated power series algebra #3665

Closed
whedon opened this issue Aug 27, 2021 · 83 comments
Closed

[PRE REVIEW]: cppTPSA/pyTPSA: a C++/Python package for truncated power series algebra #3665

whedon opened this issue Aug 27, 2021 · 83 comments
Assignees
@pibion @dtabell
Labels
C++ CMake pre-review Shell Track: 7 (CSISM) Computer science, Information Science, and Mathematics

Comments

@whedon
Copy link

whedon commented Aug 27, 2021 •
edited by editorialbot

Submitting author: @zhanghe9704 (He Zhang)
Repository: https://github.com/zhanghe9704/tpsa
Branch with paper.md (empty if default branch):
Version: v1.0.0
Editor: @pibion
Reviewers: @dtabell, @chrisrogers1234
Managing EiC: Daniel S. Katz

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/1fa756415c650531cdfd292233b4cc8d"><img src="https://joss.theoj.org/papers/1fa756415c650531cdfd292233b4cc8d/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/1fa756415c650531cdfd292233b4cc8d/status.svg)](https://joss.theoj.org/papers/1fa756415c650531cdfd292233b4cc8d)

Author instructions

Thanks for submitting your paper to JOSS @zhanghe9704. Currently, there isn't an JOSS editor assigned to your paper.

@zhanghe9704 if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @whedon is here to help you find and assign reviewers and start the main review. To find out what @whedon can do for you type:

@whedon commands
@whedon
Copy link
Author

whedon commented Aug 27, 2021

Hello human, I'm @whedon, a robot that can help you with some common editorial tasks.

⚠️ JOSS reduced service mode ⚠️

Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.

For a list of things I can do to help you, just type:

@whedon commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@whedon generate pdf

@whedon
Copy link
Author

whedon commented Aug 27, 2021

Wordcount for paper.md is 1523

@whedon
Copy link
Author

whedon commented Aug 27, 2021 

Software report (experimental):

github.com/AlDanial/cloc v 1.88  T=0.29 s (1083.2 files/s, 241410.9 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
HTML                            151            761            395          25217
C/C++ Header                      4           3194           1160          14119
TeX                              28           1100            241           7933
C++                               7            728           1379           4056
JavaScript                      100            173            200           3195
XML                               4              0            129           1954
CSS                               4            361             51           1785
Markdown                          3            133              0            200
Bourne Again Shell                1             31              9            141
SVG                               3              1              1            129
make                              2             10              0             33
DOS Batch                         1              4              0             27
CMake                             1              4              6              9
--------------------------------------------------------------------------------
SUM:                            309           6500           3571          58798
--------------------------------------------------------------------------------


Statistical information for the repository 'a2f691db07025c0871d7d47b' was
gathered on 2021/08/27.
The following historical commit information, by author, was found:

Author                     Commits    Insertions      Deletions    % of changes
He Zhang                        53         49545          21629           91.92
hezhang                          6          3316           2937            8.08

Below are the number of rows from each author that have survived and are still
intact in the current revision:

Author                     Rows      Stability          Age       % in comments
He Zhang                  28204           56.9         11.2                9.93

@whedon
Copy link
Author

whedon commented Aug 27, 2021 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- None

MISSING DOIs

- 10.1016/s1076-5670(08)x7018-1 may be a valid DOI for title: Modern Map Methods in Particle Beam Physics
- 10.2172/812598 may be a valid DOI for title: Lecture notes on topics in accelerator physics
- 10.1063/1.52348 may be a valid DOI for title: COSY INFINITY Version 9
- 10.2514/6.2018-0398 may be a valid DOI for title: Differential Algebra software library with automatic code generation for space embedded applications

INVALID DOIs

- None

@whedon
Copy link
Author

whedon commented Aug 27, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@danielskatz
Copy link

👋 @meg-simula - Do you think you edit this submission for JOSS?

@danielskatz
Copy link

@whedon invite @meg-simula as editor

@whedon
Copy link
Author

whedon commented Aug 27, 2021

@meg-simula has been invited to edit this submission.

@danielskatz
Copy link

👋 @zhanghe9704 - while we find an editor, you could work on the possibly missing DOIs that whedon suggests, but note that some may be incorrect. Please feel free to make changes to your .bib file, then use the command @whedon check references to check again, and the command @whedon generate pdf when the references are right to make a new PDF. Whedon commands need to be the first entry in a new comment.

@zhanghe9704
Copy link

zhanghe9704 commented Aug 31, 2021 via email

@whedon
Copy link
Author

whedon commented Aug 31, 2021 

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.1063/1.41975 is OK
- 10.1023/A:1024467732637 is OK
- 10.1016/j.nima.2011.01.053 is OK
- 10.1016/s1076-5670(08)x7018-1 is OK
- 10.2172/812598 is OK
- 10.1016/j.nima.2005.11.109 is OK
- 10.2514/6.2018-0398 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@zhanghe9704
Copy link

zhanghe9704 commented Aug 31, 2021 via email

@whedon
Copy link
Author

whedon commented Aug 31, 2021

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@meg-simula
Copy link

In light of the delay in response in just this editor request, I think I will have to pass on this one...

@kyleniemeyer
Copy link

@meg-simula if you are willing, I don't think checking in once a week or so is too slow of a response time, and fine with me!

@arfon
Copy link
Member

arfon commented Sep 10, 2021

Thanks to Dr. Lingyun Yang for providing his tpsa code.

@zhanghe9704 - I noticed this comment in your README and wondered if you had considered including them as an author of your submission?

@arfon
Copy link
Member

arfon commented Sep 10, 2021

@whedon invite @pibion as editor

👋 @pibion – would you be willing to edit this submission for JOSS?

@whedon
Copy link
Author

whedon commented Sep 10, 2021

@pibion has been invited to edit this submission.

@zhanghe9704
Copy link

zhanghe9704 commented Sep 10, 2021 via email

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon invite @meg-simula as editor

@whedon
Copy link
Author

whedon commented Sep 11, 2021

@meg-simula has been invited to edit this submission.

@Kevin-Mattheus-Moerman
Copy link
Member

@meg-simula if you are able to it would be great if you could help with this submission. Let us know if you can or elaborate on your comment above ☝️. No worries if you cannot. Thanks.

@Kevin-Mattheus-Moerman
Copy link
Member

@arfon sorry I see you just invited @pibion also. For some reason I missed that, I think my window here had not been refreshed yet. Well hopefully either @pibion or @meg-simula can handle this submission. Apologies for the confusion.

@meg-simula
Copy link

Not available for this one, my apologies.

@Kevin-Mattheus-Moerman
Copy link
Member

@whedon invite @pibion as editor

@whedon
Copy link
Author

whedon commented Sep 16, 2021

@pibion has been invited to edit this submission.

@pibion
Copy link

pibion commented May 9, 2022

@dtabell, would you be willing to review this submission for JOSS? We carry out our checklist-driven reviews here in GitHub issues and follow these guidelines: https://joss.readthedocs.io/en/latest/review_criteria.html.

Please let me know if you have any questions, I'm happy to communicate in whatever way works best for you - just let me know!

@dtabell
Copy link

dtabell commented May 12, 2022

@pibion Yes. I am willing to review this submission. I see the paper has languished for lack of a reviewer. I will endeavor to have this done before the end of the month. Will that suit?

@pibion
Copy link

pibion commented May 13, 2022

@editorialbot add @dtabell as reviewer

@editorialbot
Copy link
Collaborator

@dtabell added to the reviewers list!

@pibion
Copy link

pibion commented May 13, 2022

@dtabell end of month is a great time scale, thank you for volunteering as a reviewer!

@arfon I would like to start this review now even though we still need to add a second reviewer - this would let us take advantage of @dtabell 's current availability. What do you think?

@arfon
Copy link
Member

arfon commented Jul 12, 2022

@arfon I would like to start this review now even though we still need to add a second reviewer - this would let us take advantage of @dtabell 's current availability. What do you think?

Sorry I missed this. Yes, I agree you should move this forward while looking for another reviewer.

@pibion
Copy link

pibion commented Jul 22, 2022

@arfon thank you!

@pibion
Copy link

pibion commented Jul 22, 2022

@dtabell are you still available to review? If so I'll start the review now!

@arfon
Copy link
Member

arfon commented Aug 5, 2022

@pibion – it looks like you might need to find new reviewers here. This might be a good source of candidates: https://github.com/topics/power-series

@arfon
Copy link
Member

arfon commented Sep 10, 2022

👋 @pibion – this submission is still waiting to go out for review. How are you getting on finding a second reviewer?

@editorialbot editorialbot added the Track: 7 (CSISM) Computer science, Information Science, and Mathematics label Sep 10, 2022
@arfon arfon added Track: 7 (CSISM) Computer science, Information Science, and Mathematics and removed Track: 7 (CSISM) Computer science, Information Science, and Mathematics labels Sep 12, 2022
@zhanghe9704
Copy link

zhanghe9704 commented Sep 28, 2022 via email

@pibion
Copy link

pibion commented Sep 30, 2022

@zhanghe9704 I believe I've found a second reviewer, checking in with him on when he can start!

@pibion
Copy link

pibion commented Oct 5, 2022

@editorialbot assign @chrisrogers1234 as reviewer

@editorialbot
Copy link
Collaborator

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@pibion
Copy link

pibion commented Oct 5, 2022

@editorialbot commands

@editorialbot
Copy link
Collaborator

Hello @pibion, here are the things you can ask me to do:


# List all available commands
@editorialbot commands

# Add to this issue's reviewers list
@editorialbot add @username as reviewer

# Remove from this issue's reviewers list
@editorialbot remove @username from reviewers

# Get a list of all editors's GitHub handles
@editorialbot list editors

# Assign a user as the editor of this submission
@editorialbot assign @username as editor

# Remove the editor assigned to this submission
@editorialbot remove editor

# Remind an author or reviewer to return to a review after a 
# certain period of time (supported units days and weeks)
@editorialbot remind @reviewer in 2 weeks

# Check the references of the paper for missing DOIs
@editorialbot check references

# Perform checks on the repository
@editorialbot check repository

# Adds a checklist for the reviewer using this command
@editorialbot generate my checklist

# Set a value for version
@editorialbot set v1.0.0 as version

# Set a value for archive
@editorialbot set 10.21105/zenodo.12345 as archive

# Set a value for branch
@editorialbot set joss-paper as branch

# Set a value for repository
@editorialbot set https://github.com/organization/repo as repository

# Mention the EiCs for the correct track
@{bot_name} ping track-eic

# Generates the pdf paper
@editorialbot generate pdf

# Recommends the submission for acceptance
@editorialbot recommend-accept

# Generates a LaTeX preprint file
@editorialbot generate preprint

# Flag submission with questionable scope
@editorialbot query scope

# Get a link to the complete list of reviewers
@editorialbot list reviewers

# Open the review issue
@editorialbot start review

@pibion
Copy link

pibion commented Oct 5, 2022

@editorialbot add @chrisrogers1234 as reviewer

@editorialbot
Copy link
Collaborator

@chrisrogers1234 added to the reviewers list!

@pibion
Copy link

pibion commented Oct 5, 2022

@chrisrogers1234 welcome! I'm going to go ahead and start this review. We'll be joined by a second reviewer shortly, but we don't need to wait to move forward.

@pibion
Copy link

pibion commented Oct 5, 2022

@editorialbot start review

@editorialbot
Copy link
Collaborator

OK, I've started the review over in #4818.

@arfon
Copy link
Member

arfon commented Oct 1, 2023

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@editorialbot
Copy link
Collaborator

Five most similar historical JOSS papers:

PyTransport: A Python package for the calculation of inflationary correlation functions
Submitting author: @jronayne
Handling editor: @arfon (Active)
Reviewers: @joezuntz
Similarity score: 0.7882

ChebTools: C++11 (and Python) tools for working with Chebyshev expansions
Submitting author: @ianhbell
Handling editor: @labarba (Retired)
Reviewers: @drvinceknight
Similarity score: 0.7865

TESPy: Thermal Engineering Systems in Python
Submitting author: @fwitte
Handling editor: @kyleniemeyer (Active)
Reviewers: @arosen93, @corentin-dev
Similarity score: 0.7863

SARAS: A general-purpose PDE solver for fluid dynamics
Submitting author: @roshansamuel
Handling editor: @kyleniemeyer (Active)
Reviewers: @dlagrava, @olgadoronina, @nickwimer
Similarity score: 0.7862

StoSpa2: A C++ software package for stochastic simulations of spatially extended systems
Submitting author: @BartoszBartmanski
Handling editor: @pdebuyl (Active)
Reviewers: @CFGrote, @mbkumar
Similarity score: 0.7849

⚠️ Note to editors: If these papers look like they might be a good match, click through to the review issue for that paper and invite one or more of the authors before before considering asking the reviewers of these papers to review again for JOSS.

@arfon arfon mentioned this issue Oct 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pibion pibion

@dtabell dtabell

Labels
C++ CMake pre-review Shell Track: 7 (CSISM) Computer science, Information Science, and Mathematics
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests