-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: SEEDPOD Ground Risk: A Python application and library for Uncrewed Aerial Systems ground risk analysis and risk-aware path finding #4079
Comments
Hello human, I'm @whedon, a robot that can help you with some common editorial tasks. @kylebeggs, @AustinTSchaffer it looks like you're currently assigned to review this paper 🎉. Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
Wordcount for |
|
|
@kylebeggs and @AustinTSchaffer - Thanks for agreeing to review this submission. Both reviewers have checklists at the top of this thread with the JOSS requirements. As you go over the submission, please check any items that you feel have been satisfied. There are also links to the JOSS reviewer guidelines. Please read the first couple of comments in this issue carefully, so that you can accept the invitation from JOSS and be able to check items, and so that you don't get overwhelmed with notifications from other activities in JOSS. The JOSS review is different from most other journals. Our goal is to work with the authors to help them meet our criteria instead of merely passing judgment on the submission. As such, reviewers are encouraged to submit issues and pull requests on the software repository. When doing so, please mention We aim for reviews to be completed within about 2-4 weeks. Please let me know if either of you require some more time. We can also use Whedon (our bot) to set automatic reminders if you know you'll be away for a known period of time. Please feel free to ping me (@danielskatz) if you have any questions/concerns. |
👋 @kylebeggs, please update us on how your review is going (this is an automated reminder). |
👋 @AustinTSchaffer, please update us on how your review is going (this is an automated reminder). |
@kylebeggs & @AustinTSchaffer - how are things going in your reviews? Are there any problems I can help with? |
Sorry, haven't gotten to it yet. It's on my to-do, but I was out of town
this weekend. I'll take a look tonight.
…On Mon, Feb 7, 2022, 10:02 AM Daniel S. Katz ***@***.***> wrote:
@kylebeggs <https://github.com/kylebeggs> & @AustinTSchaffer
<https://github.com/AustinTSchaffer> - how are things going in your
reviews? Are there any problems I can help with?
—
Reply to this email directly, view it on GitHub
<#4079 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD3PHG4H5GC6ZVGLTZL5SRTUZ7NJLANCNFSM5MOE3A4A>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@danielskatz I am swamped with work right now. I will be able to get to it next week. If that is too long then we may have to find another reviewer. Apologies. |
That's fine - I'm just checking in to make sure it doesn't get lost... |
Hi @kylebeggs and @AustinTSchaffer - I'm just checking in again to see how your reviews are coming along |
@danielskatz Good, making my way through the source code. About to try running the software. |
@danielskatz I'm so sorry, I didn't end up looking at this 9 days ago. I added a new issue regarding Lunux installation instructions, but I definitely have most of the review still to do. I'll do a little more work later this week. |
👋 @kylebeggs and @AustinTSchaffer - I'm just checking in once again to see how your reviews are coming along |
Not great. Working through installation woes. It seems both Austin and I are on Linux and the package was more Windows focused. |
Do you think you will be able to proceed through the review? |
Depends if the authors will be able to help my issues in a timely manner. Perhaps for the sake of time we should seek another reviewer. |
👋 @aliaksei135 - What do you think? Note that if we do need to find one or two new reviewers, this will basically be like starting the review process over once we do find them, which itself can take a little time for reviewers with Windows systems. But perhaps this is best? |
|
@editorialbot generate pdf |
@aliaksei135 - I've suggested some small changes in aliaksei135/seedpod_ground_risk#107 - please merge this, or let me know what you disagree with, then we can proceed. |
All merged, thank you |
@editorialbot recommend-accept |
Paper is not ready for acceptance yet, the archive is missing |
@aliaksei135 - At this point could you:
I can then move forward with accepting the submission. |
|
@editorialbot set v0.15.1 as version |
Done! version is now v0.15.1 |
@editorialbot set 10.5281/zenodo.6363635 as archive |
Done! Archive is now 10.5281/zenodo.6363635 |
@editorialbot recommend-accept |
|
|
👋 @openjournals/joss-eics, this paper is ready to be accepted and published. Check final proof 👉 openjournals/joss-papers#3067 If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3067, then you can now move forward with accepting the submission by compiling again with the command |
@editorialbot accept |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
Congratulations to @aliaksei135 and co-author!! And thanks to @kylebeggs and @AustinTSchaffer for reviewing! |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Submitting author: @aliaksei135 (Aliaksei Pilko)
Repository: https://github.com/aliaksei135/seedpod_ground_risk/
Branch with paper.md (empty if default branch):
Version: v0.15.1
Editor: @danielskatz
Reviewers: @kylebeggs, @AustinTSchaffer
Archive: 10.5281/zenodo.6363635
Due to the challenges of the COVID-19 pandemic, JOSS is currently operating in a "reduced service mode". You can read more about what that means in our blog post.
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@kylebeggs & @AustinTSchaffer, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @danielskatz know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Review checklist for @kylebeggs
✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
Review checklist for @AustinTSchaffer
✨ Important: Please do not use the Convert to issue functionality when working through this checklist, instead, please open any new issues associated with your review in the software repository associated with the submission. ✨
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
The text was updated successfully, but these errors were encountered: