-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: DMStag: Staggered, Structured Grids for PETSc #4531
Comments
Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks. For a list of things I can do to help you, just type:
For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:
|
|
|
👋 @psanan @kris-rowe, @elauksap, @mbarzegary Each reviewer will have their own checklist, created with the command |
Wordcount for |
Review checklist for @mbarzegaryConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
Review checklist for @elauksapConflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
|
@editorialbot generate pdf |
Hi @kyleniemeyer and @psanan! I guess I completed my review of DMStag. I was able to compile the software and to run the testsuite and the tutorials succesfully. I marked all items in the checklist, including the Performance claims which do not apply in this case. Being part of a large software (PETSc) the documentation of DMStag inherits parts such as installation instructions, community guidelines, etc. But I cannot think otherwise! I would definitely recommend DMStag to be accepted for publication. Best, |
@elauksap Great to hear and thank you so much for your time and attention in reviewing our work! |
Thanks @elauksap! |
@editorialbot check references |
|
Hi @kyleniemeyer and @psanan, I guess generally it's better to open an issue on the software repo for review comments, but since the submission is part of PETSc, I put the comments here instead of opening an issue on the PETSc repo in GitLab. The software build and testing processes are straightforward as expected (I say “as expected” because it's part of PETSc), and the test cases and tutorials of DMStag build and run quite well. They also get installed using The paper is written well. However, I have some suggestions to improve the quality of the submission:
|
Thanks @mbarzegary for your feedback! This submission sort of dropped off my radar screen somehow. @psanan, can you take a look and address the above comments? |
Sorry for the delay - I will get to it ASAP. |
Hi @psanan, just wanted to check on your progress. |
Hi @kyleniemeyer , apologies for the delay - as you can tell, I'm struggling to find time to wrap this up (new job). I'm hoping that the paper will be updated soon with with most of what @mbarzegary requested. |
@editorialbot generate pdf |
Hi @psanan, there are just a few things with the references in the paper that need to be corrected:
|
Hi @kyleniemeyer. We have made the changes to the references that you have asked for and I have pushed this to our Gitlab repo. |
@editorialbot generate pdf |
@psanan looks good! At this point please archive your software repo (e.g., using Zenodo) and let me know the DOI |
Hi @kyleniemeyer - great! The version of PETSc used for this review has been uploaded to Zenodo. The DOI is
|
@editorialbot set 10.5281/zenodo.7315282 as archive |
Done! Archive is now 10.5281/zenodo.7315282 |
@editorialbot recommend-accept |
|
👋 @openjournals/pe-eics, this paper is ready to be accepted and published. Check final proof 👉📄 Download article If the paper PDF and the deposit XML files look good in openjournals/joss-papers#3722, then you can now move forward with accepting the submission by compiling again with the command |
|
@editorialbot accept |
|
🐦🐦🐦 👉 Tweet for this paper 👈 🐦🐦🐦 |
🚨🚨🚨 THIS IS NOT A DRILL, YOU HAVE JUST ACCEPTED A PAPER INTO JOSS! 🚨🚨🚨 Here's what you must now do:
Any issues? Notify your editorial technical team... |
@editorialbot remove @kris-rowe as reviewer |
@kris-rowe removed from the reviewers list! |
@editorialbot reaccept |
|
🌈 Paper updated! New PDF and metadata files 👉 openjournals/joss-papers#3724 |
Congratulations @psanan on your article's publication in JOSS! Many thanks to @elauksap and @mbarzegary for reviewing this submission. |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! The Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Awesome! Thanks so much for all your attention, @kyleniemeyer, @mbarzegary , and @elauksap! |
Submitting author: @psanan (Patrick Sanan)
Repository: https://gitlab.com/petsc/petsc
Branch with paper.md (empty if default branch): psanan/dmstag-joss
Version: v3.17.2-562-g2ed6c4b646c
Editor: @kyleniemeyer
Reviewers: @elauksap, @mbarzegary
Archive: 10.5281/zenodo.7315282
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@kris-rowe & @elauksap & @mbarzegary, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:
The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @kyleniemeyer know.
✨ Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest ✨
Checklists
📝 Checklist for @mbarzegary
📝 Checklist for @elauksap
The text was updated successfully, but these errors were encountered: