Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRE REVIEW]: ThermoCodegen: a python/C++ package for the generation of custom thermodynamic models #4632

Closed
editorialbot opened this issue Jul 31, 2022 · 34 comments

Comments

@editorialbot
Copy link
Collaborator

editorialbot commented Jul 31, 2022

Submitting author: @mspieg (Marc Spiegelman)
Repository: https://gitlab.com/ENKI-portal/ThermoCodegen
Branch with paper.md (empty if default branch): joss_paper
Version: v0.6.9
Editor: @kyleniemeyer
Reviewers: @bocklund, @rdguha1995
Managing EiC: Arfon Smith

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/776246584f3015f7ade39f695bf832fc"><img src="https://joss.theoj.org/papers/776246584f3015f7ade39f695bf832fc/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/776246584f3015f7ade39f695bf832fc/status.svg)](https://joss.theoj.org/papers/776246584f3015f7ade39f695bf832fc)

Author instructions

Thanks for submitting your paper to JOSS @mspieg. Currently, there isn't a JOSS editor assigned to your paper.

@mspieg if you have any suggestions for potential reviewers then please mention them here in this thread (without tagging them with an @). In addition, this list of people have already agreed to review for JOSS and may be suitable for this submission (please start at the bottom of the list).

Editor instructions

The JOSS submission bot @editorialbot is here to help you find and assign reviewers and start the main review. To find out what @editorialbot can do for you type:

@editorialbot commands
@editorialbot
Copy link
Collaborator Author

Hello human, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

OK DOIs

- 10.5194/gmd-2-33-2009 is OK
- 10.1029/2001GC000217 is OK
- 10.1111/j.1525-1314.1998.00140.x is OK
- 10.1111/j.1525-1314.1998.00140.x is OK
- 10.1002/2016GC006702 is OK
- 10.1007/BF00307281 is OK
- 10.1111/j.1525-1314.2010.00923.x is OK
- 10.1093/petrology/29.2.445 is OK
- 10.1111/j.1365-246X.2005.02642.x is OK
- 10.1111/j.1365-246X.2010.04890.x is OK
- 10.1111/j.1365-246X.2012.05609.x is OK
- 10.1093/gji/ggx195 is OK
- 10.5281/ZENODO.5131909 is OK
- 10.6084/M9.FIGSHARE.4865333 is OK
- 10.7916/d8-wh72-vb08 is OK

MISSING DOIs

- None

INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.88  T=3.41 s (479.5 files/s, 209436.5 lines/s)
--------------------------------------------------------------------------------
Language                      files          blank        comment           code
--------------------------------------------------------------------------------
HTML                            292          11712              0          96861
Python                          117          21704          26527          79399
Objective-C                      88          11791           4459          78039
Jupyter Notebook                282              0         149295          50965
C                                47           2949           1084          29397
C/C++ Header                    164           4504           2697          26051
XML                             132            463            123          24774
CSS                               8            298            168           9648
JavaScript                       10           2205           2244           8371
Cython                           12            216             95           7071
Markdown                        252           2112              0           6431
reStructuredText                 95           8034          19603           5212
LESS                             48            838            961           4524
SVG                               8              2             20           4016
C++                              14            141            452           2666
TeX                               3            244             16           1460
CMake                            11            247            332            764
YAML                             10             39             59            686
Bourne Shell                     28             78             48            641
make                              5             55             40            465
Dockerfile                        4             90            121            436
Java                              1             38             37            415
Bourne Again Shell                2              7             16             30
DOS Batch                         1              8              1             27
INI                               1              0              0              8
JSON                              1              0              0              1
--------------------------------------------------------------------------------
SUM:                           1636          67775         208398         438358
--------------------------------------------------------------------------------


gitinspector failed to run statistical information for the repository

@editorialbot
Copy link
Collaborator Author

Wordcount for paper.md is 1556

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@arfon arfon added the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Aug 3, 2022
@arfon
Copy link
Member

arfon commented Aug 3, 2022

@mspieg – thanks for your submission to JOSS. We're currently managing a large backlog of submissions and the editor most appropriate for your area is already rather busy.

For now, we will need to waitlist this paper and process it as the queue reduces. Thanks for your patience!

@editorialbot editorialbot added the Track: 3 (PE) Physics and Engineering label Aug 12, 2022
@arfon
Copy link
Member

arfon commented Aug 27, 2022

@editorialbot invite @leouieda as editor

👋 @leouieda – would you be willing to edit this submission for JOSS? The authors cited the work's application in Earth science and geodynamics models.

@editorialbot
Copy link
Collaborator Author

Invitation to edit this submission sent!

@leouieda
Copy link
Member

@arfon I can take this one on 👍🏾

@leouieda
Copy link
Member

@editorialbot assign @leouieda as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @leouieda is now the editor

@leouieda
Copy link
Member

👋🏾 Hi @mspieg, I'll be handling the review process for your paper.

This is a pre-review where we make sure everything is alright and try to find reviewers. The actual review will only start later on and will take place in a different issue. I'll do a first editorial pass through the submission to make sure it fits our submission requirements (I may ask for a few clarifications or modifications). If all is well, I'll proceed to inviting reviewers and once we have enough (usually 2-4) we'll start the actual review.

If you have any questions or concerns, please feel free to ping me in this issue or email me if the message needs to be private.

Please keep an eye on your GitHub notifications since this will be our primary mode of communication.

@mspieg
Copy link

mspieg commented Aug 31, 2022 via email

@mspieg
Copy link

mspieg commented Sep 9, 2022

Hi @leouieda

Just a gentle ping to see how things are going finding reviewers (and if there is anything I can do to help).

Thanks
Marc

@arfon
Copy link
Member

arfon commented Oct 16, 2022

@mspieg – I'm sorry things have been moving slowly here. @leouieda has decided to retire from the JOSS editorial team after more than 3 years of service. Thank you @leouieda 🙇

@kyleniemeyer – can you take a look at finding an alternate editor for this submission?

@kyleniemeyer
Copy link

@editorialbot assign me as editor

@editorialbot
Copy link
Collaborator Author

Assigned! @kyleniemeyer is now the editor

@kyleniemeyer
Copy link

kyleniemeyer commented Oct 16, 2022

@editorialbot invite @bryanwweber as reviewer (edit: forgot this was not actually a command 🤦‍♂️ )

Hey @bryanwweber, do you have any bandwidth to review this?

@editorialbot
Copy link
Collaborator Author

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@editorialbot commands

@kyleniemeyer
Copy link

Hi @bocklund, are you interested in and available to review this submission to JOSS?

@mspieg
Copy link

mspieg commented Oct 17, 2022 via email

@kyleniemeyer
Copy link

Hi @arosen93 and @espottesmith, are either of you able to review this submission to JOSS?

@Andrew-S-Rosen
Copy link

Hi @kyleniemeyer! Unfortunately, I'm unavailable at this time, but thank you for considering me as a reviewer.

@espottesmith
Copy link

I will unfortunately also have to decline, but I have an alternate reviewer for you: @rdguha1995.

@bocklund
Copy link

bocklund commented Oct 21, 2022

@kyleniemeyer Sorry, I lost track of this thread. I can review ThermoCodegen!

@mspieg
Copy link

mspieg commented Oct 21, 2022 via email

@kyleniemeyer
Copy link

@editorialbot add @bocklund as reviewer

Thank you! I just need to find one more.

@editorialbot
Copy link
Collaborator Author

@bocklund added to the reviewers list!

@kyleniemeyer
Copy link

Hello @rdguha1995, are you able to review this submission for JOSS?

@rdguha1995
Copy link

Hey @kyleniemeyer! Yup I can do it.

@kyleniemeyer
Copy link

@editorialbot add @rdguha1995 as reviewer

@editorialbot
Copy link
Collaborator Author

@rdguha1995 added to the reviewers list!

@kyleniemeyer
Copy link

@editorialbot start review

@editorialbot
Copy link
Collaborator Author

OK, I've started the review over in #4874.

@kyleniemeyer kyleniemeyer removed the waitlisted Submissions in the JOSS backlog due to reduced service mode. label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants